Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/core/core/server/services/url/UrlService.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function getResource has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    getResource(url, options) {
        options = options || {};

        let objects = this.urls.getByUrl(url);
Severity: Minor
Found in ghost/core/core/server/services/url/UrlService.js - About 1 hr to fix

    Function getUrlByResourceId has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        getUrlByResourceId(id, options = {}) {
        const obj = this.urls.getByResourceId(id);

        if (obj) {
            if (options.absolute) {
    Severity: Minor
    Found in ghost/core/core/server/services/url/UrlService.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getResource has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        getResource(url, options) {
        options = options || {};

        let objects = this.urls.getByUrl(url);
    Severity: Minor
    Found in ghost/core/core/server/services/url/UrlService.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

            return '/404/';
    Severity: Major
    Found in ghost/core/core/server/services/url/UrlService.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return this.utils.createUrl('/404/', false);
      Severity: Major
      Found in ghost/core/core/server/services/url/UrlService.js - About 30 mins to fix

        Function init has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            async init({onFinished, urlCache} = {}) {
        this.onFinished = onFinished;

        let persistedUrls;
        let persistedResources;
        Severity: Minor
        Found in ghost/core/core/server/services/url/UrlService.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status