Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/custom-theme-settings-service/lib/CustomThemeSettingsService.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function _syncRepositoryWithTheme has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    async _syncRepositoryWithTheme(name, theme) {
        const themeSettings = theme.customSettings || {};

        const settingsCollection = await this._repository.browse({filter: `theme:'${name}'`});
        let knownSettings = settingsCollection.toJSON();
Severity: Minor
Found in ghost/custom-theme-settings-service/lib/CustomThemeSettingsService.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateSettings has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async updateSettings(settings) {
        // abort if any settings do not match known settings
        const firstUnknownSetting = settings.find(setting => !this._activeThemeSettings[setting.key]);

        if (firstUnknownSetting) {
Severity: Minor
Found in ghost/custom-theme-settings-service/lib/CustomThemeSettingsService.js - About 1 hr to fix

    Function _syncRepositoryWithTheme has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async _syncRepositoryWithTheme(name, theme) {
        const themeSettings = theme.customSettings || {};

        const settingsCollection = await this._repository.browse({filter: `theme:'${name}'`});
        let knownSettings = settingsCollection.toJSON();
    Severity: Minor
    Found in ghost/custom-theme-settings-service/lib/CustomThemeSettingsService.js - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status