Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/data-generator/lib/importers/MembersStripeCustomersSubscriptionsImporter.js

Summary

Maintainability
D
1 day
Test Coverage

Function generate has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    generate() {
        this.count += 1;

        const member = this.model;
        const customer = this.membersStripeCustomers.get(this.model.id);
Severity: Minor
Found in ghost/data-generator/lib/importers/MembersStripeCustomersSubscriptionsImporter.js - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function generate has 139 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    generate() {
        this.count += 1;

        const member = this.model;
        const customer = this.membersStripeCustomers.get(this.model.id);
Severity: Major
Found in ghost/data-generator/lib/importers/MembersStripeCustomersSubscriptionsImporter.js - About 5 hrs to fix

    Function import has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async import() {
        let offset = 0;
        let limit = 5000;
        this.products = await this.transaction.select('id', 'name').from('products').whereNot('type', 'free');
        this.stripeProducts = await this.transaction.select('id', 'product_id', 'stripe_product_id').from('stripe_products');
    Severity: Minor
    Found in ghost/data-generator/lib/importers/MembersStripeCustomersSubscriptionsImporter.js - About 1 hr to fix

      Function import has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          async import() {
        let offset = 0;
        let limit = 5000;
        this.products = await this.transaction.select('id', 'name').from('products').whereNot('type', 'free');
        this.stripeProducts = await this.transaction.select('id', 'product_id', 'stripe_product_id').from('stripe_products');
      Severity: Minor
      Found in ghost/data-generator/lib/importers/MembersStripeCustomersSubscriptionsImporter.js - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

                          return;
      Severity: Major
      Found in ghost/data-generator/lib/importers/MembersStripeCustomersSubscriptionsImporter.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return {
            id: this.fastFakeObjectId(),
            customer_id: customer.customer_id,
            subscription_id: `sub_${faker.random.alphaNumeric(14)}`,
            stripe_price_id: stripePrice.stripe_price_id,
        Severity: Major
        Found in ghost/data-generator/lib/importers/MembersStripeCustomersSubscriptionsImporter.js - About 30 mins to fix

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                      const membersStripeCustomers = await this.transaction.select('id', 'member_id', 'customer_id').from('members_stripe_customers').limit(limit).offset(offset);
          Severity: Major
          Found in ghost/data-generator/lib/importers/MembersStripeCustomersSubscriptionsImporter.js and 3 other locations - About 35 mins to fix
          ghost/data-generator/lib/importers/MembersStatusEventsImporter.js on lines 19..19
          ghost/data-generator/lib/importers/MembersSubscribeEventsImporter.js on lines 25..25
          ghost/data-generator/lib/importers/MembersSubscriptionCreatedEventsImporter.js on lines 21..21

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status