Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/email-service/lib/EmailController.js

Summary

Maintainability
A
35 mins
Test Coverage

Function _getFrameData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    async _getFrameData(frame) {
        // Bit absurd situation in email-previews endpoints that one endpoint is using options and other one is using data.
        // So we need to handle both cases.
        let post;
        if (frame.options.id) {
Severity: Minor
Found in ghost/email-service/lib/EmailController.js - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status