Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/update-check-service/lib/UpdateCheckService.js

Summary

Maintainability
C
1 day
Test Coverage

Function createCustomNotification has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    async createCustomNotification(notification) {
        if (!notification || !notification.messages || notification.messages.length === 0) {
            debug(`Skipping notification creation as there are no messages to process`);
            return;
        }
Severity: Minor
Found in ghost/update-check-service/lib/UpdateCheckService.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createCustomNotification has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async createCustomNotification(notification) {
        if (!notification || !notification.messages || notification.messages.length === 0) {
            debug(`Skipping notification creation as there are no messages to process`);
            return;
        }
Severity: Minor
Found in ghost/update-check-service/lib/UpdateCheckService.js - About 1 hr to fix

    Function updateCheckRequest has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async updateCheckRequest() {
        const reqData = await this.updateCheckData();

        let reqObj = {
            timeout: {
    Severity: Minor
    Found in ghost/update-check-service/lib/UpdateCheckService.js - About 1 hr to fix

      Function updateCheckResponse has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async updateCheckResponse(response) {
        let notifications = [];
        let notificationGroups = (this.config.notificationGroups || []).concat(['all']);

        debug('Notification Groups', notificationGroups);
      Severity: Minor
      Found in ghost/update-check-service/lib/UpdateCheckService.js - About 1 hr to fix

        Function updateCheckData has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            async updateCheckData() {
        let data = {};
        let mailConfig = this.config.mail;

        data.ghost_version = this.config.ghostVersion;
        Severity: Minor
        Found in ghost/update-check-service/lib/UpdateCheckService.js - About 1 hr to fix

          Function updateCheckRequest has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              async updateCheckRequest() {
        const reqData = await this.updateCheckData();

        let reqObj = {
            timeout: {
          Severity: Minor
          Found in ghost/update-check-service/lib/UpdateCheckService.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateCheckData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              async updateCheckData() {
        let data = {};
        let mailConfig = this.config.mail;

        data.ghost_version = this.config.ghostVersion;
          Severity: Minor
          Found in ghost/update-check-service/lib/UpdateCheckService.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateCheckResponse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              async updateCheckResponse(response) {
        let notifications = [];
        let notificationGroups = (this.config.notificationGroups || []).concat(['all']);

        debug('Notification Groups', notificationGroups);
          Severity: Minor
          Found in ghost/update-check-service/lib/UpdateCheckService.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      const theme = (await this.api.settings.read(_.extend({key: 'active_theme'}, internal))).settings[0];
          Severity: Minor
          Found in ghost/update-check-service/lib/UpdateCheckService.js and 1 other location - About 40 mins to fix
          ghost/update-check-service/lib/UpdateCheckService.js on lines 116..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      const hash = (await this.api.settings.read(_.extend({key: 'db_hash'}, internal))).settings[0];
          Severity: Minor
          Found in ghost/update-check-service/lib/UpdateCheckService.js and 1 other location - About 40 mins to fix
          ghost/update-check-service/lib/UpdateCheckService.js on lines 117..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status