Sign upLogin

TryGhost/Ghost

View on GitHub
Star
ghost/verification-trigger/lib/VerificationTrigger.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function _startVerificationProcess has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    async _startVerificationProcess({
        amount,
        throwOnTrigger,
        source
    }) {
Severity: Minor
Found in ghost/verification-trigger/lib/VerificationTrigger.js - About 1 hr to fix

    Function testImportThreshold has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async testImportThreshold() {
        if (!isFinite(this._importTriggerThreshold)) {
            // Infinite threshold, quick path
            return;
        }
    Severity: Minor
    Found in ghost/verification-trigger/lib/VerificationTrigger.js - About 1 hr to fix

      Function _startVerificationProcess has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          async _startVerificationProcess({
        amount,
        throwOnTrigger,
        source
    }) {
      Severity: Minor
      Found in ghost/verification-trigger/lib/VerificationTrigger.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _handleMemberCreatedEvent has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          async _handleMemberCreatedEvent(event) {
        const source = event.data?.source;
        let sourceThreshold;

        if (source === 'api') {
      Severity: Minor
      Found in ghost/verification-trigger/lib/VerificationTrigger.js - About 1 hr to fix

        Function _handleMemberCreatedEvent has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            async _handleMemberCreatedEvent(event) {
        const source = event.data?.source;
        let sourceThreshold;

        if (source === 'api') {
        Severity: Minor
        Found in ghost/verification-trigger/lib/VerificationTrigger.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status