Undev/redmine-stuff-to-do-plugin

File ui.draggable.js has 491 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * jQuery UI Draggable @VERSION
 *
 * Copyright (c) 2008 AUTHORS.txt (http://ui.jquery.com/about)
 * Dual licensed under the MIT (MIT-LICENSE.txt)

Consider simplifying this complex logical expression.

Open

            if(!((l-d < x1 && x1 < r+d && t-d < y1 && y1 < b+d) || (l-d < x1 && x1 < r+d && t-d < y2 && y2 < b+d) || (l-d < x2 && x2 < r+d && t-d < y1 && y1 < b+d) || (l-d < x2 && x2 < r+d && t-d < y2 && y2 < b+d))) {
                if(inst.snapElements[i].snapping) (inst.options.snap.release && inst.options.snap.release.call(inst.element, event, $.extend(inst._uiHash(), { snapItem: inst.snapElements[i].item })));
                inst.snapElements[i].snapping = false;
                continue;
            }

Function drag has 38 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    drag: function(event, ui) {

        var inst = $(this).data("draggable"), self = this;

        var checkPos = function(o) {

Function drag has 37 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    drag: function(event, ui) {

        var inst = $(this).data("draggable");
        var d = ui.options.snapTolerance;

Function _mouseStart has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _mouseStart: function(event) {

        var o = this.options;

        //Create and append the visible helper

Function _generatePosition has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _generatePosition: function(event) {

        var o = this.options, scroll = this[(this.cssPosition == 'absolute' ? 'offset' : 'scroll')+'Parent'], scrollIsRootNode = (/(html|body)/i).test(scroll[0].tagName);

        var position = {

Function drag has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    drag: function(event, ui) {

        var o = ui.options, scrolled = false;
        var i = $(this).data("draggable");

Consider simplifying this complex logical expression.

Open

            if(!inst.snapElements[i].snapping && (ts || bs || ls || rs || first))
                (inst.options.snap.snap && inst.options.snap.snap.call(inst.element, event, $.extend(inst._uiHash(), { snapItem: inst.snapElements[i].item })));

Consider simplifying this complex logical expression.

Open

        if(!(/^(document|window|parent)$/).test(o.containment)) {
            var ce = $(o.containment)[0];
            var co = $(o.containment).offset();
            var over = ($(ce).css("overflow") != 'hidden');

Consider simplifying this complex logical expression.

Open

        if((this.options.revert == "invalid" && !dropped) || (this.options.revert == "valid" && dropped) || this.options.revert === true || ($.isFunction(this.options.revert) && this.options.revert.call(this.element, dropped))) {
            var self = this;
            $(this.helper).animate(this.originalPosition, parseInt(this.options.revertDuration, 10), function() {
                self._propagate("stop", event);
                self._clear();

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _setContainment: function() {

        var o = this.options;
        if(o.containment == 'parent') o.containment = this.helper[0].parentNode;
        if(o.containment == 'document' || o.containment == 'window') this.containment = [

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $.each(inst.sortables, function(i) {

            if(checkPos.call(inst, this.instance.containerCache)) {

                //If it intersects, we use a little isOver variable and set it once, so our move-in stuff gets fired only once

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(i.scrollParent[0] != document && i.scrollParent[0].tagName != 'HTML') {

            if((i.overflowOffset.top + i.scrollParent[0].offsetHeight) - event.pageY < o.scrollSensitivity)
                i.scrollParent[0].scrollTop = scrolled = i.scrollParent[0].scrollTop + o.scrollSpeed;
            else if(event.pageY - i.overflowOffset.top < o.scrollSensitivity)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _convertPositionTo: function(d, pos) {

        if(!pos) pos = this.position;
        var mod = d == "absolute" ? 1 : -1;
        var scroll = this[(this.cssPosition == 'absolute' ? 'offset' : 'scroll')+'Parent'], scrollIsRootNode = (/(html|body)/i).test(scroll[0].tagName);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        if(o.grid) {
            var top = this.originalPosition.top + Math.round((position.top - this.originalPosition.top) / o.grid[1]) * o.grid[1];
            position.top = this.containment ? (!(top < this.containment[1] || top > this.containment[3]) ? top : (!(top < this.containment[1]) ? top - o.grid[1] : top + o.grid[1])) : top;

            var left = this.originalPosition.left + Math.round((position.left - this.originalPosition.left) / o.grid[0]) * o.grid[0];

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if(ui.options.snapMode != 'outer') {
                var ts = Math.abs(t - y1) <= d;
                var bs = Math.abs(b - y2) <= d;
                var ls = Math.abs(l - x1) <= d;
                var rs = Math.abs(r - x2) <= d;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if(ui.options.snapMode != 'inner') {
                var ts = Math.abs(t - y2) <= d;
                var bs = Math.abs(b - y1) <= d;
                var ls = Math.abs(l - x2) <= d;
                var rs = Math.abs(r - x1) <= d;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

$.ui.plugin.add("draggable", "stack", {
    start: function(event, ui) {
        var group = $.makeArray($(ui.options.stack.group)).sort(function(a,b) {
            return (parseInt($(a).css("zIndex"),10) || ui.options.stack.min) - (parseInt($(b).css("zIndex"),10) || ui.options.stack.min);
        });

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        var position = {
            top: (
                event.pageY                                                                // The absolute mouse position
                - this.offset.click.top                                                    // Click offset (relative to the element)
                - this.offset.relative.top                                                // Only for relative positioned nodes: Relative offset from element to offset parent

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    _adjustOffsetFromHelper: function(obj) {
        if(obj.left != undefined) this.offset.click.left = obj.left + this.margins.left;
        if(obj.right != undefined) this.offset.click.left = this.helperProportions.width - obj.right + this.margins.left;
        if(obj.top != undefined) this.offset.click.top = obj.top + this.margins.top;
        if(obj.bottom != undefined) this.offset.click.top = this.helperProportions.height - obj.bottom + this.margins.top;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    start: function(event, ui) {

        var inst = $(this).data("draggable");
        inst.snapElements = [];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

$.ui.plugin.add("draggable", "iframeFix", {
    start: function(event, ui) {
        $(ui.options.iframeFix === true ? "iframe" : ui.options.iframeFix).each(function() {
            $('<div class="ui-draggable-iframeFix" style="background: #fff;"></div>')
            .css({

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _createHelper: function(event) {

        var o = this.options;
        var helper = $.isFunction(o.helper) ? $(o.helper.apply(this.element[0], [event])) : (o.helper == 'clone' ? this.element.clone() : this.element);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(this.instance.isOver) {
                this.instance.isOver = 0;
                inst.cancelHelperRemoval = true; //Don't remove the helper in the draggable instance
                this.instance.cancelHelperRemoval = false; //Remove it in the sortable instance (so sortable plugins like revert still work)
                if(this.shouldRevert) this.instance.options.revert = true; //revert here

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(!((l-d < x1 && x1 < r+d && t-d < y1 && y1 < b+d) || (l-d < x1 && x1 < r+d && t-d < y2 && y2 < b+d) || (l-d < x2 && x2 < r+d && t-d < y1 && y1 < b+d) || (l-d < x2 && x2 < r+d && t-d < y2 && y2 < b+d))) {
                if(inst.snapElements[i].snapping) (inst.options.snap.release && inst.options.snap.release.call(inst.element, event, $.extend(inst._uiHash(), { snapItem: inst.snapElements[i].item })));
                inst.snapElements[i].snapping = false;
                continue;
            }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

        if(this.containment) {
            if(position.left < this.containment[0]) position.left = this.containment[0];
            if(position.top < this.containment[1]) position.top = this.containment[1];
            if(position.left > this.containment[2]) position.left = this.containment[2];
            if(position.top > this.containment[3]) position.top = this.containment[3];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _getRelativeOffset: function() {

        if(this.cssPosition == "relative") {
            var p = this.element.position();
            return {

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

$.ui.plugin.add("draggable", "zIndex", {
    start: function(event, ui) {
        var t = $(ui.helper);
        if(t.css("zIndex")) ui.options._zIndex = t.css("zIndex");
        t.css('zIndex', ui.options.zIndex);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

$.ui.plugin.add("draggable", "opacity", {
    start: function(event, ui) {
        var t = $(ui.helper);
        if(t.css("opacity")) ui.options._opacity = t.css("opacity");
        t.css('opacity', ui.options.opacity);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _init: function() {

        if (this.options.helper == 'original' && !(/^(?:r|a|f)/).test(this.element.css("position")))
            this.element[0].style.position = 'relative';

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

$.ui.plugin.add("draggable", "cursor", {
    start: function(event, ui) {
        var t = $('body');
        if (t.css("cursor")) ui.options._cursor = t.css("cursor");
        t.css("cursor", ui.options.cursor);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _getHandle: function(event) {

        var handle = !this.options.handle || !$(this.options.handle, this.element).length ? true : false;
        $(this.options.handle, this.element)
            .find("*")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _propagate: function(n, event) {
        $.ui.plugin.call(this, n, [event, this._uiHash()]);
        if(n == "drag") this.positionAbs = this._convertPositionTo("absolute"); //The absolute position has to be recalculated after plugins
        return this.element.triggerHandler(n == "drag" ? n : "drag"+n, [event, this._uiHash()], this.options[n]);
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if((this.options.revert == "invalid" && !dropped) || (this.options.revert == "valid" && dropped) || this.options.revert === true || ($.isFunction(this.options.revert) && this.options.revert.call(this.element, dropped))) {
            var self = this;
            $(this.helper).animate(this.originalPosition, parseInt(this.options.revertDuration, 10), function() {
                self._propagate("stop", event);
                self._clear();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _mouseCapture: function(event) {

        var o = this.options;

        if (this.helper || o.disabled || $(event.target).is('.ui-resizable-handle'))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            $(this+'').each(function() {
                if($.data(this, 'sortable')) {
                    var sortable = $.data(this, 'sortable');
                    inst.sortables.push({
                        instance: sortable,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if(scrolled !== false && i.cssPosition == 'absolute' && i.scrollParent[0] != document && $.ui.contains(i.scrollParent[0], i.offsetParent[0])) {
            i.offset.parent = i._getParentOffset();
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $.extend(this.offset, {
            click: { //Where the click happened, relative to the element
                left: event.pageX - this.offset.left,
                top: event.pageY - this.offset.top
            },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if((this.offsetParent[0] == document.body && $.browser.mozilla)    //Ugly FF3 fix
        || (this.offsetParent[0].tagName && this.offsetParent[0].tagName.toLowerCase() == 'html' && $.browser.msie)) //Ugly IE fix
            po = { top: 0, left: 0 };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if(inst.snapElements[i].snapping) (inst.options.snap.release && inst.options.snap.release.call(inst.element, event, $.extend(inst._uiHash(), { snapItem: inst.snapElements[i].item })));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(!inst.snapElements[i].snapping && (ts || bs || ls || rs || first))
                (inst.options.snap.snap && inst.options.snap.snap.call(inst.element, event, $.extend(inst._uiHash(), { snapItem: inst.snapElements[i].item })));

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            var l = inst.snapElements[i].left, r = l + inst.snapElements[i].width,
                t = inst.snapElements[i].top, b = t + inst.snapElements[i].height;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _cacheMargins: function() {
        this.margins = {
            left: (parseInt(this.element.css("marginLeft"),10) || 0),
            top: (parseInt(this.element.css("marginTop"),10) || 0)
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        return {
            top: po.top + (parseInt(this.offsetParent.css("borderTopWidth"),10) || 0),
            left: po.left + (parseInt(this.offsetParent.css("borderLeftWidth"),10) || 0)
        };

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    destroy: function() {
        if(!this.element.data('draggable')) return;
        this.element.removeData("draggable").unbind(".draggable").removeClass('ui-draggable ui-draggable-dragging ui-draggable-disabled');
        this._mouseDestroy();
    },

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        if(!this.options.axis || this.options.axis != "y") this.helper[0].style.left = this.position.left+'px';

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        if(!this.options.axis || this.options.axis != "x") this.helper[0].style.top = this.position.top+'px';

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        var x1 = ui.absolutePosition.left, x2 = x1 + inst.helperProportions.width,
            y1 = ui.absolutePosition.top, y2 = y1 + inst.helperProportions.height;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        this.offset = {
            top: this.offset.top - this.margins.top,
            left: this.offset.left - this.margins.left
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        var o = this.options, scroll = this[(this.cssPosition == 'absolute' ? 'offset' : 'scroll')+'Parent'], scrollIsRootNode = (/(html|body)/i).test(scroll[0].tagName);

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        if(i.scrollParent[0] != document && i.scrollParent[0].tagName != 'HTML') i.overflowOffset = i.scrollParent.offset();

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if(scrolled !== false && $.ui.ddmanager && !o.dropBehaviour)
            $.ui.ddmanager.prepareOffsets(i, event);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    _cacheHelperProportions: function() {
        this.helperProportions = {
            width: this.helper.outerWidth(),
            height: this.helper.outerHeight()
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _uiHash: function(event) {
        return {
            helper: this.helper,
            position: this.position,
            absolutePosition: this.positionAbs,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ($.ui.ddmanager && !this.options.dropBehaviour)
            var dropped = $.ui.ddmanager.drop(this, event);

• Read up
  Read up