Undev/redmine-stuff-to-do-plugin

File ui.sortable.js has 692 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*
 * jQuery UI Sortable @VERSION
 *
 * Copyright (c) 2008 AUTHORS.txt (http://ui.jquery.com/about)
 * Dual licensed under the MIT (MIT-LICENSE.txt)

Function _mouseStart has 46 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _mouseStart: function(event, overrideHandle, noActivation) {

        var o = this.options;
        this.currentContainer = this;

Consider simplifying this complex logical expression.

Open

        if (this.floating && horizontalDirection) {
            return ((horizontalDirection == "right" && isOverRightHalf) || (horizontalDirection == "left" && !isOverRightHalf));
        } else {
            return verticalDirection && ((verticalDirection == "down" && isOverBottomHalf) || (verticalDirection == "up" && !isOverBottomHalf));
        }

Function _clear has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _clear: function(event, noPropagation) {

        this.reverting = false;

        //We first have to update the dom position of the actual currentItem

Function refreshPositions has 33 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    refreshPositions: function(fast) {

        //This has to be redone because due to the item being moved out/into the offsetParent, the offsetParent's position will change
        if(this.offsetParent && this.helper) {
            this.offset.parent = this._getParentOffset();

Function _mouseDrag has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _mouseDrag: function(event) {

        //Compute the helpers position
        this.position = this._generatePosition(event);
        this.positionAbs = this._convertPositionTo("absolute");

Function _refreshItems has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _refreshItems: function(event) {

        this.items = [];
        this.containers = [this];
        var items = this.items;

Function _generatePosition has 31 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _generatePosition: function(event) {

        var o = this.options, scroll = this[(this.cssPosition == 'absolute' ? 'offset' : 'scroll')+'Parent'], scrollIsRootNode = (/(html|body)/i).test(scroll[0].tagName);

        var position = {

Function _contactContainers has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _contactContainers: function(event) {
        for (var i = this.containers.length - 1; i >= 0; i--){

            if(this._intersectsWith(this.containers[i].containerCache)) {
                if(!this.containers[i].containerCache.over) {

Function cancel has 28 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    cancel: function() {

        if(this.dragging) {

            this._mouseUp();

Function _createPlaceholder has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _createPlaceholder: function(that) {

        var self = that || this, o = self.options;

        if(!o.placeholder || o.placeholder.constructor == String) {

Consider simplifying this complex logical expression.

Open

        if(       this.options.tolerance == "pointer"
            || this.options.forcePointerForContainers
            || (this.options.tolerance != "pointer" && this.helperProportions[this.floating ? 'width' : 'height'] > item[this.floating ? 'width' : 'height'])
        ) {
            return isOverElement;

Consider simplifying this complex logical expression.

Open

        if(!(/^(document|window|parent)$/).test(o.containment)) {
            var ce = $(o.containment)[0];
            var co = $(o.containment).offset();
            var over = ($(ce).css("overflow") != 'hidden');

Avoid deeply nested control flow statements.

Open

                        if(!itemWithLeastDistance && !this.options.dropOnEmpty) //Check if dropOnEmpty is enabled
                            continue;

Avoid deeply nested control flow statements.

Open

                        for (var j = this.items.length - 1; j >= 0; j--) {
                            if(!$.ui.contains(this.containers[i].element[0], this.items[j].item[0])) continue;
                            var cur = this.items[j][this.containers[i].floating ? 'left' : 'top'];
                            if(Math.abs(cur - base) < dist) {
                                dist = Math.abs(cur - base); itemWithLeastDistance = this.items[j];

Avoid too many return statements within this function.

Open

        return true;

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(i.scrollParent[0] != document && i.scrollParent[0].tagName != 'HTML') {

            if((i.overflowOffset.top + i.scrollParent[0].offsetHeight) - event.pageY < o.scrollSensitivity)
                i.scrollParent[0].scrollTop = scrolled = i.scrollParent[0].scrollTop + o.scrollSpeed;
            else if(event.pageY - i.overflowOffset.top < o.scrollSensitivity)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    _getItemsAsjQuery: function(connected) {

        var self = this;
        var items = [];
        var queries = [];

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _intersectsWith: function(item) {

        var x1 = this.positionAbs.left,
            x2 = x1 + this.helperProportions.width,
            y1 = this.positionAbs.top,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _convertPositionTo: function(d, pos) {

        if(!pos) pos = this.position;
        var mod = d == "absolute" ? 1 : -1;
        var scroll = this[(this.cssPosition == 'absolute' ? 'offset' : 'scroll')+'Parent'], scrollIsRootNode = (/(html|body)/i).test(scroll[0].tagName);

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

        if(o.grid) {
            var top = this.originalPosition.top + Math.round((position.top - this.originalPosition.top) / o.grid[1]) * o.grid[1];
            position.top = this.containment ? (!(top < this.containment[1] || top > this.containment[3]) ? top : (!(top < this.containment[1]) ? top - o.grid[1] : top + o.grid[1])) : top;

            var left = this.originalPosition.left + Math.round((position.left - this.originalPosition.left) / o.grid[0]) * o.grid[0];

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if(this.options.custom && this.options.custom.refreshContainers) {
            this.options.custom.refreshContainers.call(this);
        } else {
            for (var i = this.containers.length - 1; i >= 0; i--){
                var p = this.containers[i].element.offset();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        var position = {
            top: (
                event.pageY                                                                // The absolute mouse position
                - this.offset.click.top                                                    // Click offset (relative to the element)
                - this.offset.relative.top                                                // Only for relative positioned nodes: Relative offset from element to offset parent

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    _adjustOffsetFromHelper: function(obj) {
        if(obj.left != undefined) this.offset.click.left = obj.left + this.margins.left;
        if(obj.right != undefined) this.offset.click.left = this.helperProportions.width - obj.right + this.margins.left;
        if(obj.top != undefined) this.offset.click.top = obj.top + this.margins.top;
        if(obj.bottom != undefined) this.offset.click.top = this.helperProportions.height - obj.bottom + this.margins.top;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _rearrange: function(event, i, a, hardRefresh) {

        a ? a[0].appendChild(this.placeholder[0]) : i.item[0].parentNode.insertBefore(this.placeholder[0], (this.direction == 'down' ? i.item[0] : i.item[0].nextSibling));

        //Various things done here to improve the performance:

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            $(this.helper).animate({
                left: cur.left - this.offset.parent.left - self.margins.left + (this.offsetParent[0] == document.body ? 0 : this.offsetParent[0].scrollLeft),
                top: cur.top - this.offset.parent.top - self.margins.top + (this.offsetParent[0] == document.body ? 0 : this.offsetParent[0].scrollTop)
            }, parseInt(this.options.revert, 10) || 500, function() {
                self._clear(event);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                update: function(container, p) {
                    if(className && !o.forcePlaceholderSize) return;
                    if(!p.height()) { p.height(self.currentItem.innerHeight() - parseInt(self.currentItem.css('paddingTop')||0, 10) - parseInt(self.currentItem.css('paddingBottom')||0, 10)); };
                    if(!p.width()) { p.width(self.currentItem.innerWidth() - parseInt(self.currentItem.css('paddingLeft')||0, 10) - parseInt(self.currentItem.css('paddingRight')||0, 10)); };
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _getRelativeOffset: function() {

        if(this.cssPosition == "relative") {
            var p = this.currentItem.position();
            return {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _init: function() {

        var o = this.options;
        this.containerCache = {};
        this.element.addClass("ui-sortable");

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    _removeCurrentsFromItems: function() {

        var list = this.currentItem.find(":data(sortable-item)");

        for (var i=0; i < this.items.length; i++) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                co.top + (over ? Math.max(ce.scrollHeight,ce.offsetHeight) : ce.offsetHeight) - (parseInt($(ce).css("borderTopWidth"),10) || 0) - this.offset.relative.top - this.offset.parent.top - this.margins.top - (parseInt(this.currentItem.css("marginBottom"),10) || 0)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                co.left + (over ? Math.max(ce.scrollWidth,ce.offsetWidth) : ce.offsetWidth) - (parseInt($(ce).css("borderLeftWidth"),10) || 0) - this.offset.relative.left - this.offset.parent.left - this.margins.left - (parseInt(this.currentItem.css("marginRight"),10) || 0),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        for (var i = this.containers.length - 1; i >= 0; i--){
            this.containers[i]._propagate("deactivate", event, this, noPropagation);
            if(this.containers[i].containerCache.over) {
                this.containers[i]._propagate("out", event, this);
                this.containers[i].containerCache.over = 0;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    destroy: function() {
        this.element
            .removeClass("ui-sortable ui-sortable-disabled")
            .removeData("sortable")
            .unbind(".sortable");

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(this.options.handle && !overrideHandle) {
            var validHandle = false;

            $(this.options.handle, currentItem).find("*").andSelf().each(function() { if(this == event.target) validHandle = true; });
            if(!validHandle) return false;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if(scrolled !== false && i.cssPosition == 'absolute' && i.scrollParent[0] != document && $.ui.contains(i.scrollParent[0], i.offsetParent[0])) {
            i.offset.parent = i._getParentOffset();
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $.extend(this.offset, {
            click: { //Where the click happened, relative to the element
                left: event.pageX - this.offset.left,
                top: event.pageY - this.offset.top
            },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    start: function(event, ui) {
        var t = ui.helper, i = $(this).data('sortable');
        if(t.css("zIndex")) i.options._zIndex = t.css("zIndex");
        t.css('zIndex', i.options.zIndex);
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    start: function(event, ui) {
        var t = ui.helper, i = $(this).data('sortable');
        if(t.css("opacity")) i.options._opacity = t.css("opacity");
        t.css('opacity', i.options.opacity);
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if((this.offsetParent[0] == document.body && $.browser.mozilla)    //Ugly FF3 fix
        || (this.offsetParent[0].tagName && this.offsetParent[0].tagName.toLowerCase() == 'html' && $.browser.msie)) //Ugly IE fix
            po = { top: 0, left: 0 };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(this.domPosition.prev != this.currentItem.prev().not(".ui-sortable-helper")[0] || this.domPosition.parent != this.currentItem.parent()[0]) this._propagate("update", event, null, noPropagation); //Trigger update callback if the DOM position has changed

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        var currentItem = null, self = this, nodes = $(event.target).parents().each(function() {
            if($.data(this, 'sortable-item') == self) {
                currentItem = $(this);
                return false;
            }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _cacheMargins: function() {
        this.margins = {
            left: (parseInt(this.currentItem.css("marginLeft"),10) || 0),
            top: (parseInt(this.currentItem.css("marginTop"),10) || 0)
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        return {
            top: po.top + (parseInt(this.offsetParent.css("borderTopWidth"),10) || 0),
            left: po.left + (parseInt(this.offsetParent.css("borderLeftWidth"),10) || 0)
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(this._intersectsWith(this.containers[i].containerCache)) {
                if(!this.containers[i].containerCache.over) {

                    if(this.currentContainer != this.containers[i]) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(!noActivation) {
             for (var i = this.containers.length - 1; i >= 0; i--) { this.containers[i]._propagate("activate", event, this); }
        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(res) str.push((o.key || res[1]+'[]')+'='+(o.key && o.expression ? res[1] : res[2]));

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        var isOverBottomHalf = $.ui.isOverAxis(this.positionAbs.top + this.offset.click.top, item.top + (item.height/2), item.height),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(position.left + this.helperProportions.width > this.containment[2]) position.left = this.containment[2] - this.helperProportions.width;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if(position.top + this.helperProportions.height > this.containment[3]) position.top = this.containment[3] - this.helperProportions.height;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            isOverRightHalf = $.ui.isOverAxis(this.positionAbs.left + this.offset.click.left, item.left + (item.width/2), item.width),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                        itemWithLeastDistance ? this.options.sortIndicator.call(this, event, itemWithLeastDistance, null, true) : this.options.sortIndicator.call(this, event, null, this.containers[i].element, true);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        this.offset = {
            top: this.offset.top - this.margins.top,
            left: this.offset.left - this.margins.left
        };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        var o = this.options, scroll = this[(this.cssPosition == 'absolute' ? 'offset' : 'scroll')+'Parent'], scrollIsRootNode = (/(html|body)/i).test(scroll[0].tagName);

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

        if(i.scrollParent[0] != document && i.scrollParent[0].tagName != 'HTML') i.overflowOffset = i.scrollParent.offset();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _getDragHorizontalDirection: function() {
        var delta = this.positionAbs.left - this.lastPositionAbs.left;
        return delta != 0 && (delta > 0 ? "right" : "left");
    },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    _getDragVerticalDirection: function() {
        var delta = this.positionAbs.top - this.lastPositionAbs.top;
        return delta != 0 && (delta > 0 ? "down" : "up");
    },

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

                            if(Math.abs(cur - base) < dist) {
                                dist = Math.abs(cur - base); itemWithLeastDistance = this.items[j];
                            }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if(scrolled !== false && $.ui.ddmanager && !o.dropBehaviour)
            $.ui.ddmanager.prepareOffsets(i, event);

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    _cacheHelperProportions: function() {
        this.helperProportions = {
            width: this.helper.outerWidth(),
            height: this.helper.outerHeight()
        };

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            $(o.appendTo != 'parent' ? o.appendTo : this.currentItem[0].parentNode)[0].appendChild(helper[0]);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        this.domPosition = { prev: this.currentItem.prev()[0], parent: this.currentItem.parent()[0] };

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        var isOverElementHeight = $.ui.isOverAxis(this.positionAbs.top + this.offset.click.top, item.top, item.height),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            isOverElementWidth = $.ui.isOverAxis(this.positionAbs.left + this.offset.click.left, item.left, item.width),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(helper[0].style.height == '' || o.forceHelperSize) helper.height(this.currentItem.height());

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if(helper[0].style.width == '' || o.forceHelperSize) helper.width(this.currentItem.width());

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        var dontCancel = !noPropagation ? this.element.triggerHandler(n == "sort" ? n : "sort"+n, [event, this._ui(inst)], this.options[n]) : true;

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if($.ui.contains(this.containers[i].element[0], this.currentItem[0])) {
                    this.containers[i]._propagate("update", event, this, noPropagation);
                    this.containers[i]._propagate("receive", event, this, noPropagation);
                }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        if ($.ui.ddmanager && !this.options.dropBehaviour)
            $.ui.ddmanager.drop(this, event);

• Read up
  Read up