Sign upLogin

Undev/redmine_non_member_watcher

View on GitHub
Star

Showing 8 of 12 total issues

Method allowed_to_condition_for_authors has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

      def allowed_to_condition_for_authors(user, permission, options={}, &block)
        if Role.non_member_author.allowed_to?(permission)
          base_statement = "#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"
          if perm = Redmine::AccessControl.permission(permission)
            unless perm.project_module.nil?
Severity: Minor
Found in lib/redmine_non_member_watcher/patches/project_patch.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method allowed_to_condition_for_watchers has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

      def allowed_to_condition_for_watchers(user, permission, options={}, &block)
        if Role.non_member_watcher.allowed_to?(permission)
          base_statement = "#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"
          if perm = Redmine::AccessControl.permission(permission)
            unless perm.project_module.nil?
Severity: Minor
Found in lib/redmine_non_member_watcher/patches/project_patch.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method visible_condition_with_watched_issues has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def visible_condition_with_watched_issues(user, options={})
        Project.allowed_to_condition(user, :view_issues, options) do |role, user|
          if user.logged?

            # Add watched issues to list if allowed
Severity: Minor
Found in lib/redmine_non_member_watcher/patches/issue_patch.rb - About 1 hr to fix

    Method allowed_to_with_non_member_roles? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def allowed_to_with_non_member_roles?(action, context, options={}, &block)
      allowed_to_without_non_member_roles?(action, context, options, &block) ||
        if logged? && context && context.is_a?(Project)
          roles = roles_for_project(context)
          roles.any? { |role|
    Severity: Minor
    Found in lib/redmine_non_member_watcher/patches/user_patch.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method visible_condition_with_watched_issues has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def visible_condition_with_watched_issues(user, options={})
        Project.allowed_to_condition(user, :view_issues, options) do |role, user|
          if user.logged?

            # Add watched issues to list if allowed
    Severity: Minor
    Found in lib/redmine_non_member_watcher/patches/issue_patch.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method allowed_to_condition_for_authors has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def allowed_to_condition_for_authors(user, permission, options={}, &block)
        if Role.non_member_author.allowed_to?(permission)
          base_statement = "#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"
          if perm = Redmine::AccessControl.permission(permission)
            unless perm.project_module.nil?
    Severity: Minor
    Found in lib/redmine_non_member_watcher/patches/project_patch.rb - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

              if logged? && context && context.is_a?(Project)
          roles = roles_for_project(context)
          roles.any? { |role|
            (role == Role.non_member_watcher || role == Role.non_member_author) &&
              role.allowed_to?(action) &&
      Severity: Major
      Found in lib/redmine_non_member_watcher/patches/user_patch.rb - About 40 mins to fix

        Method visible_condition_with_non_member_roles has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

              def visible_condition_with_non_member_roles(user, options={})
        conditions = []
        conditions << visible_condition_with_watched_issues(user, options)

        if user.logged?
        Severity: Minor
        Found in lib/redmine_non_member_watcher/patches/issue_patch.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language