Sign upLogin

UniSharp/laravel-filemanager

View on GitHub
Star

Showing 27 of 35 total issues

Method getNewName has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function getNewName($file)
    {
        $new_file_name = $this->helper->translateFromUtf8(
            trim($this->helper->utf8Pathinfo($file->getClientOriginalName(), "filename"))
        );
Severity: Minor
Found in src/LfmPath.php - About 1 hr to fix

    Method doMove has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function doMove()
    {
        $target = $this->helper->input('goToFolder');
        $items = $this->helper->input('items');
    Severity: Minor
    Found in src/Controllers/ItemsController.php - About 1 hr to fix

      Function upload has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function upload()
    {
        $uploaded_files = request()->file('upload');
        $error_bag = [];
        $new_filename = null;
      Severity: Minor
      Found in src/Controllers/UploadController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getAddfolder has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getAddfolder()
    {
        $folder_name = $this->helper->input('name');

        $new_path = $this->lfm->setName($folder_name)->path('absolute');
      Severity: Minor
      Found in src/Controllers/FolderController.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return parent::$success_response;
      Severity: Major
      Found in src/Controllers/FolderController.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return response()->json(parent::error('rename'), 400);
        Severity: Major
        Found in src/Controllers/RenameController.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return parent::$success_response;
          Severity: Major
          Found in src/Controllers/RenameController.php - About 30 mins to fix
            Severity
            Category
            Status
            Source
            Language