Function main
has 277 lines of code (exceeds 25 allowed). Consider refactoring. Open
function main (options) {
self.options = options;
console.log('options', options)
var host = options.host;
File test_runner.js
has 511 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**
* Copyright 2015-2016 Unicity International
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Function main
has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring. Open
function main (options) {
self.options = options;
console.log('options', options)
var host = options.host;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function runTest
has 75 lines of code (exceeds 25 allowed). Consider refactoring. Open
function runTest (test) {
var promise = q.defer();
test.start = Date.now();
request.post(test.requestOptions, function (err, res, body) {
test.end = Date.now();
Function deepCompare
has 50 lines of code (exceeds 25 allowed). Consider refactoring. Open
function deepCompare (ar1, ar2) {
var matches = true;
var type1 = typeof ar1;
var type2 = typeof ar2;
Function deepCompare
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
function deepCompare (ar1, ar2) {
var matches = true;
var type1 = typeof ar1;
var type2 = typeof ar2;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function processQueue
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
function processQueue (queue) {
var promise = q.defer();
var tests = queue.slice(); // makes shallow copy
var running = 0;
var max = options.maxWorkers;
Function sendToS3
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
function sendToS3 (obj, name, type, client) {
var string = obj;
var promise = q.defer();
var contentType;
Function outputTest
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function outputTest (test) {
var Text = 'Test: ';
var endPoint = test.endpoint;
var subTest = test.name;
var testPath = endPoint + '.' + subTest;
Function getDifferencesUrl
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function getDifferencesUrl (actual, expected, type, diffUrl, client) {
Function testResponseTime
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
function testResponseTime (test) {
if (test.ms) {
var totalTime = test.end - test.start;
var maxTime = (100 * test.ms) / 85;
test.maxTime = maxTime;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function testJSON
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
function testJSON (test, expected, actual, options) {
var promise = q.defer();
var expectedOutput = parseJSON(expected);
var actualOutput = parseJSON(actual);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
FIXME found Open
// FIXME simplify if/else statement
- Exclude checks
FIXME found Open
commandLineTests.forEach(function (commandLineTest) { // FIXME unnecessarily looping through the entire loop
- Exclude checks
FIXME found Open
} // FIXME where no secret, 'client' is not initialized
- Exclude checks
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (deepCompare(expectedOutput, actualOutput)) {
test.passed = true;
promise.resolve();
}
else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 84.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (valid){
test.passed = true;
promise.resolve();
} else {
test.passed = false;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 84.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
} else {
Text += colors.red(testPath + ' passed, but took too long (expected time ' + test.ms +' ms. Max run time ' + test.maxTime.toFixed(0)+' ms )');
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 54.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
} else if (test.warnOnTime) {
Text += colors.yellow(testPath + ' passed, but exceeded warning threshold (expected time ' + test.ms +' ms. Max run time ' + test.maxTime.toFixed(0)+' ms )');
} else {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 54.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Parsing error: Invalid ecmaVersion. Open
/**
- Read upRead up
- Exclude checks
For more information visit Source: http://eslint.org/docs/rules/