VIAplanner/via-timetable

View on GitHub
src/timetable-planner/combinations/combinations.spec.js

Summary

Maintainability
F
2 wks
Test Coverage

File combinations.spec.js has 959 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import test from 'ava';
import {
  courseMeetingSectionCombinations,
  courseCombinations,
} from './combinations';
Severity: Major
Found in src/timetable-planner/combinations/combinations.spec.js - About 2 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const SECTIONS_L1_T2 = {
      code: 'CSC108H5F',
      combinations: [
        [
          {
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 1 other location - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 234..322

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 317.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const SECTIONS_L1_P2 = {
      code: 'CSC108H5F',
      combinations: [
        [
          {
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 1 other location - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 323..411

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 317.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const COURSE_L1_P2 = {
      code: 'CSC108H5F',
      meeting_sections: [
        {
          code: 'L0101',
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 1 other location - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 65..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 212.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const COURSE_L1_T2 = {
      code: 'CSC108H5F',
      meeting_sections: [
        {
          code: 'L0101',
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 1 other location - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 7..64

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 212.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        [
          {
            code: 'CSC108H5FL0102',
            instructors: ['A Petersen'],
            times: [
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 7 other locations - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 415..469
    src/timetable-planner/combinations/combinations.spec.js on lines 470..524
    src/timetable-planner/combinations/combinations.spec.js on lines 525..579
    src/timetable-planner/combinations/combinations.spec.js on lines 580..634
    src/timetable-planner/combinations/combinations.spec.js on lines 690..744
    src/timetable-planner/combinations/combinations.spec.js on lines 745..799
    src/timetable-planner/combinations/combinations.spec.js on lines 800..854

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        [
          {
            code: 'CSC108H5FL0102',
            instructors: ['A Petersen'],
            times: [
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 7 other locations - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 415..469
    src/timetable-planner/combinations/combinations.spec.js on lines 470..524
    src/timetable-planner/combinations/combinations.spec.js on lines 525..579
    src/timetable-planner/combinations/combinations.spec.js on lines 580..634
    src/timetable-planner/combinations/combinations.spec.js on lines 635..689
    src/timetable-planner/combinations/combinations.spec.js on lines 745..799
    src/timetable-planner/combinations/combinations.spec.js on lines 800..854

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        [
          {
            code: 'CSC108H5FL0102',
            instructors: ['A Petersen'],
            times: [
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 7 other locations - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 415..469
    src/timetable-planner/combinations/combinations.spec.js on lines 470..524
    src/timetable-planner/combinations/combinations.spec.js on lines 525..579
    src/timetable-planner/combinations/combinations.spec.js on lines 580..634
    src/timetable-planner/combinations/combinations.spec.js on lines 635..689
    src/timetable-planner/combinations/combinations.spec.js on lines 690..744
    src/timetable-planner/combinations/combinations.spec.js on lines 800..854

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        [
          {
            code: 'CSC108H5FL0101',
            instructors: ['A Petersen'],
            times: [
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 7 other locations - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 415..469
    src/timetable-planner/combinations/combinations.spec.js on lines 470..524
    src/timetable-planner/combinations/combinations.spec.js on lines 525..579
    src/timetable-planner/combinations/combinations.spec.js on lines 635..689
    src/timetable-planner/combinations/combinations.spec.js on lines 690..744
    src/timetable-planner/combinations/combinations.spec.js on lines 745..799
    src/timetable-planner/combinations/combinations.spec.js on lines 800..854

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        [
          {
            code: 'CSC108H5FL0102',
            instructors: ['A Petersen'],
            times: [
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 7 other locations - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 415..469
    src/timetable-planner/combinations/combinations.spec.js on lines 470..524
    src/timetable-planner/combinations/combinations.spec.js on lines 525..579
    src/timetable-planner/combinations/combinations.spec.js on lines 580..634
    src/timetable-planner/combinations/combinations.spec.js on lines 635..689
    src/timetable-planner/combinations/combinations.spec.js on lines 690..744
    src/timetable-planner/combinations/combinations.spec.js on lines 745..799

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        [
          {
            code: 'CSC108H5FL0101',
            instructors: ['A Petersen'],
            times: [
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 7 other locations - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 470..524
    src/timetable-planner/combinations/combinations.spec.js on lines 525..579
    src/timetable-planner/combinations/combinations.spec.js on lines 580..634
    src/timetable-planner/combinations/combinations.spec.js on lines 635..689
    src/timetable-planner/combinations/combinations.spec.js on lines 690..744
    src/timetable-planner/combinations/combinations.spec.js on lines 745..799
    src/timetable-planner/combinations/combinations.spec.js on lines 800..854

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        [
          {
            code: 'CSC108H5FL0101',
            instructors: ['A Petersen'],
            times: [
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 7 other locations - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 415..469
    src/timetable-planner/combinations/combinations.spec.js on lines 470..524
    src/timetable-planner/combinations/combinations.spec.js on lines 580..634
    src/timetable-planner/combinations/combinations.spec.js on lines 635..689
    src/timetable-planner/combinations/combinations.spec.js on lines 690..744
    src/timetable-planner/combinations/combinations.spec.js on lines 745..799
    src/timetable-planner/combinations/combinations.spec.js on lines 800..854

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

        [
          {
            code: 'CSC108H5FL0101',
            instructors: ['A Petersen'],
            times: [
    Severity: Major
    Found in src/timetable-planner/combinations/combinations.spec.js and 7 other locations - About 1 day to fix
    src/timetable-planner/combinations/combinations.spec.js on lines 415..469
    src/timetable-planner/combinations/combinations.spec.js on lines 525..579
    src/timetable-planner/combinations/combinations.spec.js on lines 580..634
    src/timetable-planner/combinations/combinations.spec.js on lines 635..689
    src/timetable-planner/combinations/combinations.spec.js on lines 690..744
    src/timetable-planner/combinations/combinations.spec.js on lines 745..799
    src/timetable-planner/combinations/combinations.spec.js on lines 800..854

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 195.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status