ValiMail/dane-discovery

View on GitHub

Showing 21 of 33 total issues

Function clean_up_certificate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def clean_up_certificate(cls, certificate):
        """This method returns a clean PEM-encoded certificate.
        
        This is useful for removing the human-readable certificate
        metadata that sometimes ends up in certificates produced 
Severity: Minor
Found in dane_discovery/pki.py - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language