Sign upLogin

Valve/emarsys-broadcast-ruby

View on GitHub
Star

Showing 2 of 4 total issues

Method validate_config has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def validate_config(config)
        raise ConfigurationError, 'configuration is nil, did you forget to configure the gem?' unless config
        raise ConfigurationError, 'api_host must be configured' unless string_present? config.api_host
        raise ConfigurationError, 'api_user must be configured' unless string_present? config.api_user
        raise ConfigurationError, 'api_password must be configured' unless string_present? config.api_password
Severity: Minor
Found in lib/emarsys/broadcast/http.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method validate_config has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def validate_config(config)
        raise ConfigurationError, 'configuration is nil, did you forget to configure the gem?' unless config
        raise ConfigurationError, 'sftp_host must be configured' unless string_present? config.sftp_host
        raise ConfigurationError, 'sftp_user must be configured' unless string_present? config.sftp_user
        raise ConfigurationError, 'sftp_password must be configured' unless string_present? config.sftp_password
Severity: Minor
Found in lib/emarsys/broadcast/sftp.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language