Sign upLogin

Vizir/react-native-simple-login

View on GitHub
Star
Login/component.spec.js

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    Forms.ResetPasswordForm = (props) => {
      return (
        <Button
          title='submit'
          onPress={() => props.onResetPassword('email')} />
Severity: Minor
Found in Login/component.spec.js and 1 other location - About 40 mins to fix
Login/component.spec.js on lines 92..98

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      Forms.ResetPasswordForm = (props) => {
        return (
          <Button
            title='submit'
            onPress={() => props.onResetPassword('email')} />
Severity: Minor
Found in Login/component.spec.js and 1 other location - About 40 mins to fix
Login/component.spec.js on lines 48..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

      const wrapper = shallow(
        <Login onLogin={jest.fn()} onResetPassword={jest.fn()} />
      )
Severity: Minor
Found in Login/component.spec.js and 2 other locations - About 30 mins to fix
Login/component.spec.js on lines 17..19
Login/component.spec.js on lines 81..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

    const wrapper = shallow(
      <Login onLogin={jest.fn()} onResetPassword={jest.fn()} />
    )
Severity: Minor
Found in Login/component.spec.js and 2 other locations - About 30 mins to fix
Login/component.spec.js on lines 81..83
Login/component.spec.js on lines 101..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

      const wrapper = shallow(
        <Login onLogin={jest.fn()} onResetPassword={jest.fn()} />
      )
Severity: Minor
Found in Login/component.spec.js and 2 other locations - About 30 mins to fix
Login/component.spec.js on lines 17..19
Login/component.spec.js on lines 101..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Component definition is missing display name
Open

      Forms.ResetPasswordForm = (props) => {
Severity: Minor
Found in Login/component.spec.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

'onResetPassword' is missing in props validation
Open

            onPress={() => props.onResetPassword('email')} />
Severity: Minor
Found in Login/component.spec.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

'onResetPasswordClick' is missing in props validation
Open

            onPress={() => props.onResetPasswordClick()} />
Severity: Minor
Found in Login/component.spec.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

'onLogin' is missing in props validation
Open

          onPress={() => props.onLogin('email', 'password')} />
Severity: Minor
Found in Login/component.spec.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Component definition is missing display name
Open

      Forms.LoginForm = (props) => {
Severity: Minor
Found in Login/component.spec.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

'onResetPassword' is missing in props validation
Open

          onPress={() => props.onResetPassword('email')} />
Severity: Minor
Found in Login/component.spec.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status