Sign upLogin

Vizzuality/cartowrap

View on GitHub
Star

Showing 4 of 4 total issues

Method initialize has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

      def initialize(http_status, response_body, error_info = nil)
        if response_body
          self.response_body = response_body.strip
        else
          self.response_body = ''
Severity: Minor
Found in lib/cartowrap/errors.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method initialize has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def initialize(http_status, response_body, error_info = nil)
        if response_body
          self.response_body = response_body.strip
        else
          self.response_body = ''
Severity: Minor
Found in lib/cartowrap/errors.rb - About 1 hr to fix

    Method endpoint_uri has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def endpoint_uri
        query = options.q if options.q
        resource = options.resource_id if options.resource_id
        string = ""
        api = options.endpoint
    Severity: Minor
    Found in lib/cartowrap/http_service/endpoint.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method make_request has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.make_request(options, credentials={})
      http_method = options.http_method&.to_sym || :get
      account = credentials["account"] if credentials["account"]
      carto_url = credentials["carto_url"] || "https://#{account}.carto.com"
      endpoint = Endpoint.new(options, credentials).get
    Severity: Minor
    Found in lib/cartowrap/http_service.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language