Vizzuality/gfw-climate

View on GitHub
app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function preCacheMonths has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    preCacheMonths: function(rows, coord, zoom, zoom_diff) {
      var row, xcoords, ycoords, deforestation;

      if (typeof ArrayBuffer !== 'undefined') {
        xcoords = new Uint8Array(new ArrayBuffer(rows.length));
Severity: Minor
Found in app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js - About 1 hr to fix

    Function _render has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _render: function(tile) {
          var month = this.endMonth || -BASE_MONTH + MAX_MONTHS;
          var month_start = this.startMonth || 0;
          var month_change = this.top_date;
          var w = tile.canvas.width;
    Severity: Minor
    Found in app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js - About 1 hr to fix

      Function getTile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getTile: function(coord, zoom, ownerDocument) {
            var canvas = this._getCanvas(coord, zoom, ownerDocument);
            var sql = this._getSQL(coord.x, coord.y, zoom);
            var zoomDiff = zoom + 8 - Math.min(zoom + 8, 16);
      
      
      Severity: Minor
      Found in app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              this.startMonth = Math.abs(
                moment(this.layer.mindate).diff(this.currentDate[0], 'months')
              );
        Severity: Minor
        Found in app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js on lines 243..245

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              this.endMonth = Math.abs(
                moment(this.layer.mindate).diff(this.currentDate[1], 'months')
              );
        Severity: Minor
        Found in app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js and 1 other location - About 40 mins to fix
        app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js on lines 240..242

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

            _getLayer: function() {
              var deferred = new $.Deferred();
              deferred.resolve(this);
              return deferred.promise();
            },
        Severity: Minor
        Found in app/assets/javascripts/abstract/layer/CanvasJSONLayerClass.js and 2 other locations - About 30 mins to fix
        app/assets/javascripts/abstract/layer/CanvasLayerClass.js on lines 24..28
        app/assets/javascripts/abstract/layer/ImageLayerClass.js on lines 23..27

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status