Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/assets/javascripts/countries/views/CountryReportView.js

Summary

Maintainability
D
2 days
Test Coverage

File CountryReportView.js has 451 lines of code (exceeds 250 allowed). Consider refactoring.
Open

define(
  [
    'backbone',
    'handlebars',
    'mps',
Severity: Minor
Found in app/assets/javascripts/countries/views/CountryReportView.js - About 6 hrs to fix

    Function parseTemplate has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          parseTemplate: function() {
        var currentDate = moment();
        var totalReference = '';
        var totalMonitoring = '';
        var increase = '';
    Severity: Major
    Found in app/assets/javascripts/countries/views/CountryReportView.js - About 2 hrs to fix

      Function _initModules has 55 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            _initModules: function() {
        this._initSlides();
        this.summaryChart = new SummaryChartView({
          data: this.data.emissions,
          country: this.data.country,
      Severity: Major
      Found in app/assets/javascripts/countries/views/CountryReportView.js - About 2 hrs to fix

        Function _initCrownSlider has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              _initCrownSlider: function() {
        this.crownSlider = document.getElementById('crown-cover-slider');
        nouislider.create(this.crownSlider, {
          start: this.status.get('thresh'),
          animate: true,
        Severity: Minor
        Found in app/assets/javascripts/countries/views/CountryReportView.js - About 1 hr to fix

          Function _subscribeUpdates has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                _subscribeUpdates: function(ev) {
        ev.preventDefault();
        var btnContainer = this.$el.find('#report-updates-submit');
        btnContainer.addClass('is-loading');
        var emailInput = this.$el.find('#sign-up-email');
          Severity: Minor
          Found in app/assets/javascripts/countries/views/CountryReportView.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (
          !params.params.exclude_plantations &&
          this._hasPlantations(params.iso) &&
          this._isDefaultExcludePlantations(params.iso)
        ) {
            Severity: Major
            Found in app/assets/javascripts/countries/views/CountryReportView.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/countries/views/CountryReportView.js on lines 93..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (
          !params.params.primary_forest &&
          this._hasPrimaryForest(params.iso) &&
          this._isDefaultPrimaryForest(params.iso)
        ) {
            Severity: Major
            Found in app/assets/javascripts/countries/views/CountryReportView.js and 1 other location - About 1 hr to fix
            app/assets/javascripts/countries/views/CountryReportView.js on lines 100..106

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 64.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      excludePlantations: {
            disabled: !this._hasPlantations(this.options.iso),
            checked: this.status.get('exclude_plantations') === 'true'
          },
            Severity: Minor
            Found in app/assets/javascripts/countries/views/CountryReportView.js and 1 other location - About 45 mins to fix
            app/assets/javascripts/countries/views/CountryReportView.js on lines 197..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      primaryForest: {
            disabled: !this._hasPrimaryForest(this.options.iso),
            checked: this.status.get('primary_forest') === 'true'
          },
            Severity: Minor
            Found in app/assets/javascripts/countries/views/CountryReportView.js and 1 other location - About 45 mins to fix
            app/assets/javascripts/countries/views/CountryReportView.js on lines 201..204

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 50.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status