Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/assets/javascripts/countries/views/report/SummaryChartView.js

Summary

Maintainability
F
6 days
Test Coverage

File SummaryChartView.js has 409 lines of code (exceeds 250 allowed). Consider refactoring.
Open

define(
  [
    'backbone',
    'handlebars',
    'underscore',
Severity: Minor
Found in app/assets/javascripts/countries/views/report/SummaryChartView.js - About 5 hrs to fix

    Function _drawAxis has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          _drawAxis: function() {
        var _this = this;

        // X Axis
        var xAxis = this.svg
    Severity: Minor
    Found in app/assets/javascripts/countries/views/report/SummaryChartView.js - About 1 hr to fix

      Function _initYearSlider has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            _initYearSlider: function() {
        nouislider.create(this.yearsSlider, {
          start: [
            this.defaults.startYear,
            this.defaults.commonYear,
      Severity: Minor
      Found in app/assets/javascripts/countries/views/report/SummaryChartView.js - About 1 hr to fix

        Function _drawDots has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              _drawDots: function() {
        var _this = this;
        var dotsGroup = this.svg
          .append('g')
          .attr('class', 'dots-group')
        Severity: Minor
        Found in app/assets/javascripts/countries/views/report/SummaryChartView.js - About 1 hr to fix

          Function _parseData has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                _parseData: function() {
        var tzOffset = new Date().getTimezoneOffset() + 60;
        this.chartData = [];

        for (var indictator in this.data) {
          Severity: Minor
          Found in app/assets/javascripts/countries/views/report/SummaryChartView.js - About 1 hr to fix

            Function _setAxisScale has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  _setAxisScale: function() {
        var _this = this;
        var xTickFormat = d3.time.format(_this.defaults.dateFormat);
        var yTickFormat = function(d) {
          return d > 999 ? d / 1000 + 'k' : d;
            Severity: Minor
            Found in app/assets/javascripts/countries/views/report/SummaryChartView.js - About 1 hr to fix

              Function _drawSolidLine has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    _drawSolidLine: function() {
        var _this = this;
        var solidLineGroup = this.svg
          .append('g')
          .attr('class', 'line-group')
              Severity: Minor
              Found in app/assets/javascripts/countries/views/report/SummaryChartView.js - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        dotsGroup
          .selectAll('.dot.reference')
          .data(this.referenceData.values)
          .enter()
          .append('circle')
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 4 hrs to fix
                app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 455..467

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 128.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        dotsGroup
          .selectAll('.dot.monitoring')
          .data(this.monitoringData.values)
          .enter()
          .append('circle')
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 4 hrs to fix
                app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 469..481

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 128.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                      remove: function(params) {
        if (this.svg) {
          var svgContainer = this.chartEl.querySelector('svg');

          if (params && !params.keepEvents) {
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 3 other locations - About 4 hrs to fix
                app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js on lines 923..935
                app/assets/javascripts/countries/views/report/PieChartView.js on lines 219..231
                app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 585..597

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 120.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 5 locations. Consider refactoring.
                Open

                        var svg = d3
          .select(el)
          .append('svg')
          .attr('width', this.cWidth + margin.left + margin.right + 'px')
          .attr('height', this.cHeight + margin.top + margin.bottom + 'px');
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 4 other locations - About 2 hrs to fix
                app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js on lines 203..207
                app/assets/javascripts/countries/views/report/PieChartView.js on lines 149..153
                app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 157..161
                app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 283..287

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 89.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                      _initChart: function() {
        // Data parsing and initialization
        this._parseData();
        this.hasData = this.chartData && this.chartData.length;
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 2 other locations - About 2 hrs to fix
                app/assets/javascripts/countries/views/report/PieChartView.js on lines 52..62
                app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 75..85

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 84.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        var yAxis = this.svg
          .append('g')
          .attr('class', 'y axis')
          .attr(
            'transform',
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 2 hrs to fix
                app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 448..458

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 75.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        this.yAxis = d3.svg
          .axis()
          .scale(this.y)
          .orient('left')
          .innerTickSize(0)
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 1 hr to fix
                app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 356..363

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 74.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        var dotsGroup = this.svg
          .append('g')
          .attr('class', 'dots-group')
          .attr(
            'transform',
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 1 hr to fix
                app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 405..415

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        var solidLineGroup = this.svg
          .append('g')
          .attr('class', 'line-group')
          .attr(
            'transform',
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 1 hr to fix
                app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 443..453

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 71.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        var xAxis = this.svg
          .append('g')
          .attr('class', 'x axis')
          .attr('transform', 'translate(0,' + this.cHeight + ')')
          .call(this.xAxis);
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 1 hr to fix
                app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 431..435

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        this.xAxis = d3.svg
          .axis()
          .scale(this.x)
          .orient('bottom')
          .innerTickSize(-this.cHeight)
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 1 hr to fix
                app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 345..351

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 63.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                      setListeners: function() {
        this.refreshEvent = _.debounce(_.bind(this._update, this), 30);
        window.addEventListener('resize', this.refreshEvent, false);
      },
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 3 other locations - About 1 hr to fix
                app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js on lines 134..137
                app/assets/javascripts/countries/views/report/PieChartView.js on lines 92..95
                app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 116..119

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 62.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 4 locations. Consider refactoring.
                Open

                      render: function() {
        this._setUpGraph();
        this._setAxisScale();
        this._setDomain();
        this._drawAxis();
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 3 other locations - About 1 hr to fix
                app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js on lines 123..129
                app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 105..111
                app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 224..230

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        this.graphLine = solidLineGroup
          .append('path')
          .attr('d', this.linePath(this.monitoringData.values))
          .attr('class', 'line-monitoring');
                Severity: Minor
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 55 mins to fix
                app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 427..430

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 53.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        this.graphLine = solidLineGroup
          .append('path')
          .attr('d', this.linePath(this.referenceData.values))
          .attr('class', 'line-reference');
                Severity: Minor
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 55 mins to fix
                app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 432..435

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 53.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 4 locations. Consider refactoring.
                Open

                        this.svg = svg
          .append('g')
          .attr(
            'transform',
            'translate(' + margin.left + ',' + margin.top + ')'
                Severity: Major
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 3 other locations - About 50 mins to fix
                app/assets/javascripts/countries/views/report/HistoricalTrendChartView.js on lines 209..214
                app/assets/javascripts/countries/views/report/ProvincesTopChartView.js on lines 163..168
                app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 313..318

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 52.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            if (value[1] === value[2]) {
              this.yearsSlider.noUiSlider.set([
                value[0],
                parseInt(value[2], 10) - 1,
                value[2]
                Severity: Minor
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 40 mins to fix
                app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 115..121

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                            } else if (value[0] === value[1]) {
              this.yearsSlider.noUiSlider.set([
                value[0],
                parseInt(value[0], 10) + 1,
                value[2]
                Severity: Minor
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 40 mins to fix
                app/assets/javascripts/countries/views/report/SummaryChartView.js on lines 109..121

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        xAxis
          .selectAll('line')
          .attr('x1', _this.defaults.paddingXAxisLabels)
          .attr('x2', _this.defaults.paddingXAxisLabels);
                Severity: Minor
                Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 35 mins to fix
                app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 442..445

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 47.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status