Vizzuality/gfw-climate

View on GitHub
app/assets/javascripts/data-download/views/DataDownloadIndexView.js

Summary

Maintainability
D
2 days
Test Coverage

File DataDownloadIndexView.js has 474 lines of code (exceeds 250 allowed). Consider refactoring.
Open

define(
  [
    'backbone',
    'handlebars',
    'bluebird',
Severity: Minor
Found in app/assets/javascripts/data-download/views/DataDownloadIndexView.js - About 7 hrs to fix

    Function onCountryChange has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          onCountryChange: function(selection) {
            var jurisIndex = this.filterIndex.jurisdiction_ids;
            var aoiIndex = this.filterIndex.area_ids;
            var jurisView = this.filterViews[jurisIndex];
            var aoiView = this.filterViews[aoiIndex];
    Severity: Major
    Found in app/assets/javascripts/data-download/views/DataDownloadIndexView.js - About 2 hrs to fix

      Function onDataSourceChange has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            onDataSourceChange: function(selection) {
              var years = [];
              var trhesAllowed = false;
      
              if (selection && selection.length) {
      Severity: Major
      Found in app/assets/javascripts/data-download/views/DataDownloadIndexView.js - About 2 hrs to fix

        Function onIndicatorsChange has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              onIndicatorsChange: function(selection) {
                var dataSourceOptions = [];
                this.availableIndicators = [];
                this.widgets.forEach(function(widget) {
                  if (
        Severity: Minor
        Found in app/assets/javascripts/data-download/views/DataDownloadIndexView.js - About 1 hr to fix

          Function onDownloadClick has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                onDownloadClick: function(e) {
                  e.preventDefault();
                  var downloadUrl = '/api/data_portal_downloads'; // TODO: move this to .env
                  var query = '';
                  var firstParam = true;
          Severity: Minor
          Found in app/assets/javascripts/data-download/views/DataDownloadIndexView.js - About 1 hr to fix

            Function render has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  render: function() {
                    this.filtersContainer.html(this.template({ filters: this.filters }));
                    this.filters.forEach(function(filter, index) {
                      var view = new DownloadFilterCardView({
                        el: '#' + filter.id + '-filter-card',
            Severity: Minor
            Found in app/assets/javascripts/data-download/views/DataDownloadIndexView.js - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      {
                        el: 'outputTypeSwitch',
                        param: 'pivot',
                        label: 'Output Type',
                        options: [
              app/assets/javascripts/data-download/views/DataDownloadIndexView.js on lines 76..84

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      {
                        el: 'filerSwitch',
                        param: 'json',
                        label: 'File',
                        options: [
              app/assets/javascripts/data-download/views/DataDownloadIndexView.js on lines 67..75

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 52.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if ((index === 0 && firstParam) || query === '') {
                            firstParam = false;
                            query += '?';
                          } else {
                            query += '&';
              app/assets/javascripts/data-download/views/DataDownloadIndexView.js on lines 475..480

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          if ((index === 0 && firstParam) || query === '') {
                            firstParam = false;
                            query += '?';
                          } else {
                            query += '&';
              app/assets/javascripts/data-download/views/DataDownloadIndexView.js on lines 488..493

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 48.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                            var parseData = function(items) {
                              return items.map(function(item) {
                                return {
                                  value: item.id,
                                  name: item.name
              app/assets/javascripts/widgets/indicators/stacked/StackedChart.js on lines 76..80

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status