Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/assets/javascripts/embed/views/pantropical/PantropicalView.js

Summary

Maintainability
F
1 wk
Test Coverage

File PantropicalView.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

define(
  [
    'backbone',
    'chosen',
    'embed/views/pantropical/PantropicalTotalEmissionsView',
Severity: Minor
Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js - About 3 hrs to fix

    Function _hideYears has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          _hideYears: function(elementID) {
        var $opositeSelector;
        var selectedYear;
        var condition;
        var value;
    Severity: Minor
    Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js - About 1 hr to fix

      Function _player has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            _player: function() {
        if (this.$play_pause.hasClass('is-playing')) {
          window.setTimeout(
            function() {
              this.progression += 100 / this.ticks;
      Severity: Minor
      Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              _player: function() {
        if (this.$play_pause.hasClass('is-playing')) {
          window.setTimeout(
            function() {
              this.progression += 100 / this.ticks;
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 1 day to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 283..320

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 349.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              _hideYears: function(elementID) {
        var $opositeSelector;
        var selectedYear;
        var condition;
        var value;
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 1 day to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 146..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 332.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              _search_country: function(e) {
        d3.selection.prototype.moveToFront = function() {
          return this.each(function() {
            this.parentNode.appendChild(this);
          });
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 1 day to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 252..275

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 299.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              _cacheVars: function() {
        this.$years = $('#year-picker');
        this.$yearsPickerLabel = $('#year-picker-label');
        this.$play_pause = $('#play-pause');
        this.$playBtn = this.$play_pause.find('.play');
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 1 day to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 59..70

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 204.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              _setAutocomplete: function() {
        this.$search.chosen({
          width: '100%'
        });
        d3.csv(
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 1 day to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 225..250

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 200.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              _setLabelPosition: function(year) {
        var width = this.$years.width();
        var newPlace;

        // Figure out placement percentage between left and right of input
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 6 hrs to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 200..218

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 166.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

              _shareToSocial: function(e) {
        e && e.preventDefault();
        var width = 575,
          height = 400,
          left = ($(window).width() - width) / 2,
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 2 other locations - About 6 hrs to fix
        app/assets/javascripts/views/ShareView.js on lines 271..291
        app/assets/javascripts/widgets/views/ShareWidgetView.js on lines 250..270

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 156.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              initialize: function() {
        //I can't find who is giving display:block to country tab...
        var currentTab = location.search.split('tab=')[1];
        $('#vis')
          .find('.country')
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 4 hrs to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 37..53

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 134.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if (this.$play_pause.hasClass('stop')) {
          this._play();
        } else {
          this.$playBtn.removeClass('is-hidden');
          this.$pauseBtn.addClass('is-hidden');
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 3 hrs to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 335..345

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                } else if (element.id == 'year-drop-right') {
          element2 = document.getElementById('year-drop-left');
          this.year_right = parseInt(
            element.options[element.selectedIndex].value
          );
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 3 hrs to fix
        app/assets/javascripts/embed/views/pantropical/PantropicalView.js on lines 111..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                if (element.id == 'year-drop-left') {
          element2 = document.getElementById('year-drop-right');
          this.year_left = parseInt(
            element.options[element.selectedIndex].value
          );
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 3 hrs to fix
        app/assets/javascripts/embed/views/pantropical/PantropicalView.js on lines 120..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 96.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              _updateUrl: function(viewId) {
        history.pushState(
          '',
          document.title,
          window.location.origin + window.location.pathname + '?tab=' + viewId
        Severity: Major
        Found in app/assets/javascripts/embed/views/pantropical/PantropicalView.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/countries/views/CountryPantropicalView.js on lines 97..103

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status