Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/assets/javascripts/map/views/LegendView.js

Summary

Maintainability
D
2 days
Test Coverage

File LegendView.js has 610 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * Legend module.
 *
 * @return singleton instance of the legend class (extends Widget).
 */
Severity: Major
Found in app/assets/javascripts/map/views/LegendView.js - About 1 day to fix

    Function _renderLegend has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        _renderLegend: function(categories, options, geographic) {
      var iso = null;
      var layersGlobal = [];
      var layersIso = [];
      var categoriesGlobal = [];
    Severity: Major
    Found in app/assets/javascripts/map/views/LegendView.js - About 2 hrs to fix

      Function _getLayerData has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _getLayerData: function(layer, opts) {
      var unitsList = [];
      var selectedUnit =
        !!opts.rangearray && opts.rangearray[layer.slug]
          ? opts.rangearray[layer.slug].unit
      Severity: Minor
      Found in app/assets/javascripts/map/views/LegendView.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              values.max =
        !!opts.rangearray && opts.rangearray[layer.slug]
          ? opts.rangearray[layer.slug].maxrange
          : false || (!!defaultRange ? defaultRange.max : null);
        Severity: Major
        Found in app/assets/javascripts/map/views/LegendView.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/map/views/LegendView.js on lines 501..504

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              values.min =
        !!opts.rangearray && opts.rangearray[layer.slug]
          ? opts.rangearray[layer.slug].minrange
          : false || (!!defaultRange ? defaultRange.min : null);
        Severity: Major
        Found in app/assets/javascripts/map/views/LegendView.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/map/views/LegendView.js on lines 506..509

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 75.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            _toggleLayer: function(event) {
      var layerSlug = $(event.currentTarget).data('sublayer');
      this.presenter.toggleLayer(layerSlug);
    },
        Severity: Minor
        Found in app/assets/javascripts/map/views/LegendView.js and 1 other location - About 50 mins to fix
        app/assets/javascripts/countries/views/show/TabsView.js on lines 26..29

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            events: {
      'click .category-name': '_toogleCategory',
      'click .layer-sublayer': '_toggleLayer',
      'click .canopy-button': '_showCanopy',
      'click .layer-close': '_removeLayer',
        Severity: Minor
        Found in app/assets/javascripts/map/views/LegendView.js and 1 other location - About 50 mins to fix
        app/assets/javascripts/map/views/MapControlsView.js on lines 45..55

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                biomass_loss: {
          ranges: {
            tco: {
              min: 0,
              max: 900,
        Severity: Minor
        Found in app/assets/javascripts/map/views/LegendView.js and 1 other location - About 35 mins to fix
        app/assets/javascripts/map/views/LegendView.js on lines 85..99

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          var carbonGainConfig = {
    ranges: {
      tco: {
        min: 0,
        max: 440
        Severity: Minor
        Found in app/assets/javascripts/map/views/LegendView.js and 1 other location - About 35 mins to fix
        app/assets/javascripts/map/views/LegendView.js on lines 115..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status