Vizzuality/gfw-climate

View on GitHub
app/assets/javascripts/map/views/controls/SearchboxView.js

Summary

Maintainability
C
1 day
Test Coverage

File SearchboxView.js has 283 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * The Searchbox module.
 *
 * @return searchbox class (extends Backbone.View).
 */
Severity: Minor
Found in app/assets/javascripts/map/views/controls/SearchboxView.js - About 2 hrs to fix

    Function setListeners has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          setListeners: function() {
            this.$input.on(
              'keyup',
              _.bind(function(e) {
                if (e.keyCode === 27) {
    Severity: Major
    Found in app/assets/javascripts/map/views/controls/SearchboxView.js - About 2 hrs to fix

      Function checkSearchType has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            checkSearchType: function(address) {
              if (this.$searchbox.hasClass('blocked')) return;
              var isLatLong = function(address) {
                return (
                  (address.includes('º') || address.includes('°')) &&
      Severity: Minor
      Found in app/assets/javascripts/map/views/controls/SearchboxView.js - About 1 hr to fix

        Function _setType has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              _setType: function(e, kind) {
                this.$searchbox.addClass('blocked');
                if (!!e && !!!kind) {
                  var $target = $(e.target);
                  if ($target.hasClass('selected')) return;
        Severity: Minor
        Found in app/assets/javascripts/map/views/controls/SearchboxView.js - About 1 hr to fix

          Similar blocks of code found in 12 locations. Consider refactoring.
          Open

                  enquire.register(
                    'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
                    {
                      match: _.bind(function() {
                        this.mobile = true;
          app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
          app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
          app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
          app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
          app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
          app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
          app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
          app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
          app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
          app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
          app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 12 locations. Consider refactoring.
          Open

                  enquire.register(
                    'screen and (min-width:' + window.gfw.config.GFW_MOBILE + 'px)',
                    {
                      match: _.bind(function() {
                        this.mobile = false;
          app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
          app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
          app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
          app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
          app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
          app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
          app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
          app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
          app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
          app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
          app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 63.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status