Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/assets/javascripts/map/views/layers/LossLayer.js

Summary

Maintainability
C
1 day
Test Coverage

Function filterCanvasImgdata has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      filterCanvasImgdata: function(imgdata, w, h, z) {
        var components = 4;
        var exp = z < 11 ? 0.3 + (z - 3) / 20 : 1;
        if (!!!this.currentDate[0]._d) {
          this.currentDate[0] = moment(this.currentDate[0]);
Severity: Minor
Found in app/assets/javascripts/map/views/layers/LossLayer.js - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            if (
          !!options.currentDate &&
          options.currentDate[0] > options.currentDate[1]
        ) {
          var kllm = options.currentDate[1];
    Severity: Major
    Found in app/assets/javascripts/map/views/layers/LossLayer.js and 1 other location - About 3 hrs to fix
    app/assets/javascripts/map/views/layers/BiomassLossLayer.js on lines 30..38

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 99.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

            if (!!!this.currentDate[0]._d) {
          this.currentDate[0] = moment(this.currentDate[0]);
          this.currentDate[1] = moment(this.currentDate[1]);
        }
    Severity: Major
    Found in app/assets/javascripts/map/views/layers/LossLayer.js and 3 other locations - About 2 hrs to fix
    app/assets/javascripts/abstract/timeline/TimelineYearClass.js on lines 132..135
    app/assets/javascripts/abstract/timeline/TimelineYearClass.js on lines 235..238
    app/assets/javascripts/map/views/layers/BiomassLossLayer.js on lines 67..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 4 locations. Consider refactoring.
    Open

          _getUrl: function(x, y, z) {
        return new UriTemplate(this.options.urlTemplate).fillFromObject({
          x: x,
          y: y,
          z: z,
    Severity: Major
    Found in app/assets/javascripts/map/views/layers/LossLayer.js and 3 other locations - About 1 hr to fix
    app/assets/javascripts/map/views/layers/BiomassLossLayer.js on lines 141..148
    app/assets/javascripts/map/views/layers/CarbonStocksLayer.js on lines 113..120
    app/assets/javascripts/map/views/layers/Forest2000Layer.js on lines 75..82

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            var myscale = d3.scale
          .pow()
          .exponent(exp)
          .domain([0, 256])
          .range([0, 256]);
    Severity: Minor
    Found in app/assets/javascripts/map/views/layers/LossLayer.js and 2 other locations - About 40 mins to fix
    app/assets/javascripts/map/views/layers/BiomassLossLayer.js on lines 74..78
    app/assets/javascripts/map/views/layers/Forest2000Layer.js on lines 39..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status