Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star
app/assets/javascripts/widgets/views/TabView.js

Summary

Maintainability
C
1 day
Test Coverage

Function setIndicator has 133 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      setIndicator: function() {
        var t = this.presenter.status.get('tabs');
        var indicators;
        if (t && t.type) {
          switch (t.type) {
Severity: Major
Found in app/assets/javascripts/widgets/views/TabView.js - About 5 hrs to fix

    File TabView.js has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    define(
  [
    'backbone',
    'underscore',
    'handlebars',
    Severity: Minor
    Found in app/assets/javascripts/widgets/views/TabView.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            changeStartDate: function(e) {
        var startYear = $(e.currentTarget).val();
        ga('send', 'event', 'Widget', 'Start year', startYear);
        this.presenter.changeStartDate(startYear);
      },
      Severity: Major
      Found in app/assets/javascripts/widgets/views/TabView.js and 1 other location - About 1 hr to fix
      app/assets/javascripts/widgets/views/TabView.js on lines 99..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            changeEndDate: function(e) {
        var endYear = $(e.currentTarget).val();
        ga('send', 'event', 'Widget', 'End year', endYear);
        this.presenter.changeEndDate(endYear);
      },
      Severity: Major
      Found in app/assets/javascripts/widgets/views/TabView.js and 1 other location - About 1 hr to fix
      app/assets/javascripts/widgets/views/TabView.js on lines 93..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 59.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status