Sign upLogin

Vizzuality/gfw-climate

View on GitHub
Star

Showing 920 of 1,213 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      this.x = d3.time
        .scale()
        .range([
          this.options.innerPadding.left,
          this.width - this.options.innerPadding.right
Severity: Major
Found in app/assets/javascripts/widgets/indicators/multiline/MultiLineChart.js and 2 other locations - About 1 hr to fix
app/assets/javascripts/widgets/indicators/line/LineChart.js on lines 80..85
app/assets/javascripts/widgets/indicators/stacked/StackedChart.js on lines 111..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (resource.iso) {
          p.iso = {};
          p.iso.country = resource.iso;
          p.iso.region = resource.id1 ? resource.id1 : null;
        } else if (resource.geojson) {
Severity: Major
Found in app/assets/javascripts/map/presenters/tabs/SubscriptionPresenter.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/presenters/tabs/AnalysisPresenter.js on lines 797..807

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        if (resource.iso) {
          p.iso = {};
          p.iso.country = resource.iso;
          p.iso.region = resource.id1 ? resource.id1 : null;
        } else if (resource.geostore) {
Severity: Major
Found in app/assets/javascripts/map/presenters/tabs/AnalysisPresenter.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/presenters/tabs/SubscriptionPresenter.js on lines 519..527

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      _onOverlayComplete: function(e) {
        ga('send', 'event', 'Map', 'Analysis', 'Polygon: complete');
        this.presenter.onOverlayComplete(e);
        this._resetDrawing();
        // buttons clases
Severity: Major
Found in app/assets/javascripts/map/views/tabs/SubscriptionView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/views/tabs/AnalysisView.js on lines 463..469

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

      _onOverlayComplete: function(e) {
        ga('send', 'event', 'Map', 'Analysis', 'Polygon: complete');
        this.presenter.onOverlayComplete(e);
        this._resetDrawing();
        // buttons clases
Severity: Major
Found in app/assets/javascripts/map/views/tabs/AnalysisView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/views/tabs/SubscriptionView.js on lines 408..414

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          if (event.pageY < 100) {
            $('#headerGfw').addClass('-show');
            $('.logo-menu').addClass('-show');
            $('.nav-sections').addClass('-show');
            $('.layout-header-bottom').addClass('-show');
Severity: Major
Found in app/assets/javascripts/map/views/MapView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/views/MapView.js on lines 657..673

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

define(
  ['abstract/layer/CartoDBLayerClass', 'text!map/cartocss/wwf.cartocss'],
  function(CartoDBLayerClass, wwfCartoCSS) {
    'use strict';
Severity: Major
Found in app/assets/javascripts/map/views/layers/WWFLayer.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/views/layers/ConcesionesForestalesNotSupervisedLayer.js on lines 6..27

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (
          !params.params.primary_forest &&
          this._hasPrimaryForest(params.iso) &&
          this._isDefaultPrimaryForest(params.iso)
        ) {
Severity: Major
Found in app/assets/javascripts/countries/views/CountryReportView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/countries/views/CountryReportView.js on lines 100..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (
          !params.params.exclude_plantations &&
          this._hasPlantations(params.iso) &&
          this._isDefaultExcludePlantations(params.iso)
        ) {
Severity: Major
Found in app/assets/javascripts/countries/views/CountryReportView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/countries/views/CountryReportView.js on lines 93..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if (
              !hoverCarbonLoss &&
              !hoverMenuLogin &&
              !hoverCarbonGains &&
              !hoverCarbonDensity &&
Severity: Major
Found in app/assets/javascripts/map/views/MapView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/views/MapView.js on lines 625..630

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

define(
  [
    'abstract/layer/CartoDBLayerClass',
    'text!map/cartocss/concesiones_peruTypes.cartocss'
  ],
Severity: Major
Found in app/assets/javascripts/map/views/layers/ConcesionesForestalesNotSupervisedLayer.js and 1 other location - About 1 hr to fix
app/assets/javascripts/map/views/layers/WWFLayer.js on lines 6..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        enquire.register(
          'screen and (min-width:' + window.gfw.config.GFW_MOBILE + 'px)',
          {
            match: _.bind(function() {
              this.mobile = false;
Severity: Major
Found in app/assets/javascripts/map/views/tabs/BasemapsView.js and 11 other locations - About 1 hr to fix
app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        enquire.register(
          'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
          {
            match: _.bind(function() {
              this.mobile = true;
Severity: Major
Found in app/assets/javascripts/map/views/controls/SearchboxView.js and 11 other locations - About 1 hr to fix
app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        enquire.register(
          'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
          {
            match: _.bind(function() {
              this.mobile = true;
Severity: Major
Found in app/assets/javascripts/map/views/analysis/AnalysisResultsView.js and 11 other locations - About 1 hr to fix
app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        enquire.register(
          'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
          {
            match: _.bind(function() {
              this.mobile = true;
Severity: Major
Found in app/assets/javascripts/widgets/views/DownloadWidgetView.js and 11 other locations - About 1 hr to fix
app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            _.bind(function() {
              $tab.find('.source_header').addClass('active');
              $tab.find('.source_body').show(0);
              this.calculateOffsets();
            }, this)
Severity: Major
Found in app/assets/javascripts/views/SidebarNavView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/views/SidebarNavView.js on lines 241..245

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        enquire.register(
          'screen and (min-width:' + window.gfw.config.GFW_MOBILE + 'px)',
          {
            match: _.bind(function() {
              this.mobile = false;
Severity: Major
Found in app/assets/javascripts/widgets/views/DownloadWidgetView.js and 11 other locations - About 1 hr to fix
app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    enquire.register(
      'screen and (max-width:' + window.gfw.config.GFW_MOBILE + 'px)',
      {
        match: _.bind(function() {
          this.mobile = true;
Severity: Major
Found in app/assets/javascripts/widgets/indicators/pie/PieChart.js and 11 other locations - About 1 hr to fix
app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 41..48
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        var xAxis = this.svg
          .append('g')
          .attr('class', 'x axis')
          .attr('transform', 'translate(0,' + this.cHeight + ')')
          .call(this.xAxis);
Severity: Major
Found in app/assets/javascripts/countries/views/report/SummaryChartView.js and 1 other location - About 1 hr to fix
app/assets/javascripts/insights/views/glad-alerts/InsightsGladAlertsChartView.js on lines 431..435

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

        enquire.register(
          'screen and (min-width:' + window.gfw.config.GFW_MOBILE + 'px)',
          {
            match: _.bind(function() {
              this.mobile = false;
Severity: Major
Found in app/assets/javascripts/map/views/controls/SearchboxView.js and 11 other locations - About 1 hr to fix
app/assets/javascripts/compare/views/CompareIndexView.js on lines 33..40
app/assets/javascripts/compare/views/CompareIndexView.js on lines 42..49
app/assets/javascripts/compare/views/index/CompareSelectorsView.js on lines 37..44
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 60..67
app/assets/javascripts/map/views/analysis/AnalysisResultsView.js on lines 68..75
app/assets/javascripts/map/views/controls/SearchboxView.js on lines 49..56
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 46..53
app/assets/javascripts/map/views/tabs/BasemapsView.js on lines 54..61
app/assets/javascripts/widgets/indicators/pie/PieChart.js on lines 10..17
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 42..49
app/assets/javascripts/widgets/views/DownloadWidgetView.js on lines 51..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language