WikiEducationFoundation/WikiEduDashboard

View on GitHub
app/assets/javascripts/reducers/tickets.js

Summary

Maintainability
C
1 day
Test Coverage
A
91%

Function default has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function (state = initialState, action) {
  switch (action.type) {
    case DELETE_TICKET: {
      const all = removeTicket(state.all, action.id);
      return {
Severity: Major
Found in app/assets/javascripts/reducers/tickets.js - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

          return {
            ...state,
            all: state.all.concat(action.data),
            loading: false
          };
    Severity: Major
    Found in app/assets/javascripts/reducers/tickets.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

            return {
              ...state,
              all: sorted.newModels,
              sort: {
                sortKey: sorted.newKey,
      Severity: Major
      Found in app/assets/javascripts/reducers/tickets.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return {
                ...state,
                all,
                selected: { ...action.data.ticket }
              };
        Severity: Major
        Found in app/assets/javascripts/reducers/tickets.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                return {
                  ...state,
                  all,
                  selected
                };
          Severity: Major
          Found in app/assets/javascripts/reducers/tickets.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            const removeNote = (notes, id) => {
              const note = notes.find(item => item.id === id);
              const index = notes.indexOf(note);
              return [
                ...notes.slice(0, index),
            Severity: Major
            Found in app/assets/javascripts/reducers/tickets.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/reducers/tickets.js on lines 48..56

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            const removeTicket = (tickets, id) => {
              const ticket = tickets.find(tick => tick.id === id);
              const index = tickets.indexOf(ticket);
            
              return [
            Severity: Major
            Found in app/assets/javascripts/reducers/tickets.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/reducers/tickets.js on lines 58..65

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 87.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                case SORT_TICKETS: {
                  const sorted = sortByKey(state.all, action.key, state.sort.sortKey, SORT_DESCENDING[action.key]);
            
                  return {
                    ...state,
            Severity: Major
            Found in app/assets/javascripts/reducers/tickets.js and 4 other locations - About 2 hrs to fix
            app/assets/javascripts/reducers/active_courses.js on lines 29..44
            app/assets/javascripts/reducers/campaigns.js on lines 56..71
            app/assets/javascripts/reducers/course_search_results.js on lines 30..45
            app/assets/javascripts/reducers/wiki_courses.js on lines 27..42

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 85.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Parsing error: Cannot find module 'babel-plugin-root-import' Require stack: - /usr/local/node_modules/@babel/core/lib/config/files/plugins.js - /usr/local/node_modules/@babel/core/lib/config/files/index.js - /usr/local/node_modules/@babel/core/lib/index.js - /usr/local/node_modules/@babel/eslint-parser/lib/worker/babel-core.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/worker/handle-message.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/client.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/index.cjs - /usr/local/node_modules/eslint/lib/cli-engine/config-array-factory.js - /usr/src/app/lib/eslint6-patch.js - /usr/src/app/lib/eslint.js - /usr/src/app/bin/eslint.js
            Open

            import {

            For more information visit Source: http://eslint.org/docs/rules/

            There are no issues that match your filters.

            Category
            Status