Sign upLogin

WikiEducationFoundation/WikiEduDashboard

View on GitHub
Star
app/assets/javascripts/surveys/modules/Survey.js

Summary

Maintainability
F
3 days
Test Coverage
C
74%

File Survey.js has 636 lines of code (exceeds 250 allowed). Consider refactoring.
Open

//--------------------------------------------------------
// Vendor Requirements [imports]
//--------------------------------------------------------
import { assign, throttle } from 'lodash-es';
import Rails from '@rails/ujs';
Severity: Major
Found in app/assets/javascripts/surveys/modules/Survey.js - About 1 day to fix

    Survey has 51 functions (exceeds 20 allowed). Consider refactoring.
    Open

    const Survey = {

  currentBlock: 0,
  submitted: [],
  submittedAll: false,
    Severity: Major
    Found in app/assets/javascripts/surveys/modules/Survey.js - About 7 hrs to fix

      Function initRangeSliders has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        initRangeSliders() {
    $('[data-range]').each((i, slider) => {
      const $input = $(slider).next('[data-range-field]');
      const min = parseInt($(slider).data('min'));
      const max = parseInt($(slider).data('max'));
      Severity: Minor
      Found in app/assets/javascripts/surveys/modules/Survey.js - About 1 hr to fix

        Function initSlider has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          initSlider() {
    this.$surveyContainer = $('[data-survey-form-container]');
    this.parentSlider = this.$surveyContainer.slick(assign({}, slickOptions, { adaptiveHeight: false }));

    this.parentSlider.on('init', (e, slick) => {
        Severity: Minor
        Found in app/assets/javascripts/surveys/modules/Survey.js - About 1 hr to fix

          Function validateCurrentQuestion has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            validateCurrentQuestion(e) {
    e.preventDefault();
    const $target = $(e.target);
    const $block = $target.parents('.block');
    this.$currentBlock = $block;
          Severity: Minor
          Found in app/assets/javascripts/surveys/modules/Survey.js - About 1 hr to fix

            Function handleParentConditionalChange has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              handleParentConditionalChange(value, conditionalGroup, $parent) {
    let { currentAnswers } = conditionalGroup;
    let conditional;
    // let resetQuestions = false;
            Severity: Minor
            Found in app/assets/javascripts/surveys/modules/Survey.js - About 1 hr to fix

              Function processQuestionGroupData has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                processQuestionGroupData(data) {
    const _postData = {};
    const answerGroup = {};
    data.forEach((field) => {
      const { name } = field;
              Severity: Minor
              Found in app/assets/javascripts/surveys/modules/Survey.js - About 1 hr to fix

                Function validateCurrentQuestion has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  validateCurrentQuestion(e) {
    e.preventDefault();
    const $target = $(e.target);
    const $block = $target.parents('.block');
    this.$currentBlock = $block;
                Severity: Minor
                Found in app/assets/javascripts/surveys/modules/Survey.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function handleParentConditionalChange has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  handleParentConditionalChange(value, conditionalGroup, $parent) {
    let { currentAnswers } = conditionalGroup;
    let conditional;
    // let resetQuestions = false;
                Severity: Minor
                Found in app/assets/javascripts/surveys/modules/Survey.js - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      $(slider).on('beforeChange', (e, slick, currentSlide) => {
        if (!this.currentBlockValidated) {
          e.preventDefault();
        } else {
          this.toggleTabNavigationForQuestion(false, slick, currentSlide);
                Severity: Minor
                Found in app/assets/javascripts/surveys/modules/Survey.js and 1 other location - About 50 mins to fix
                app/assets/javascripts/surveys/modules/Survey.js on lines 142..148

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    this.parentSlider.on('beforeChange', (e, slick, currentSlide) => {
      if (!this.currentBlockValidated) {
        e.preventDefault();
      } else {
        this.toggleTabNavigationForQuestion(false, slick, currentSlide);
                Severity: Minor
                Found in app/assets/javascripts/surveys/modules/Survey.js and 1 other location - About 50 mins to fix
                app/assets/javascripts/surveys/modules/Survey.js on lines 159..165

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 51.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Parsing error: Cannot find module 'babel-plugin-root-import' Require stack: - /usr/local/node_modules/@babel/core/lib/config/files/plugins.js - /usr/local/node_modules/@babel/core/lib/config/files/index.js - /usr/local/node_modules/@babel/core/lib/index.js - /usr/local/node_modules/@babel/eslint-parser/lib/worker/babel-core.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/worker/handle-message.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/client.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/index.cjs - /usr/local/node_modules/eslint/lib/cli-engine/config-array-factory.js - /usr/src/app/lib/eslint6-patch.js - /usr/src/app/lib/eslint.js - /usr/src/app/bin/eslint.js
                Open

                //--------------------------------------------------------
                Severity: Minor
                Found in app/assets/javascripts/surveys/modules/Survey.js by eslint

                For more information visit Source: http://eslint.org/docs/rules/

                There are no issues that match your filters.

                Category
                Status