Sign upLogin

XYOracleNetwork/sdk-xyo-swift

View on GitHub
Star

Showing 189 of 674 total issues

Function bridge has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  func bridge() throws {
    guard semaphore == true, knownBridges.count > 0 else {
      if knownBridges.count == 0 {
        print("No known bridges")
      }
Severity: Minor
Found in Sources/sdk-xyo-swift/Clients/XyoTcpipClient.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function disconnect has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    func disconnect(from device: XYBluetoothDevice) {
        print("STEP 1: Trying to DISCONNECT from \(device.id.shortId)...")

        let disconnectQueue = DispatchQueue(label: "com.xyfindables.sdk.ConnectionManagerDisconnectQueueFor\(device.id)")
Severity: Minor
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/XYDeviceConnectionManager.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function detected has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

  public override func detected(_ rssi: Int) {
        guard self.isUpdatingFirmware == false else { return }

        var events: [XYFinderEventNotification] = [.detected(device: self, powerLevel: Int(self.powerLevel), rssi: self.rssi, distance: 0)]
Severity: Minor
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Devices/Base/XYFinderDeviceBase.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doBoundWitness has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  func doBoundWitness(withDevice: XyoBluetoothDevice, withCompletion: BoundWitnessCallback) throws {
    
      self.delegate?.boundWitness(started: withDevice.id)

      withDevice.connection {
Severity: Minor
Found in Source/Clients/XyoBleClient.swift - About 1 hr to fix

    Function doBoundWitness has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      func doBoundWitness(withDevice: XyoBluetoothDevice, withCompletion: BoundWitnessCallback) throws {
    
      self.delegate?.boundWitness(started: withDevice.id)

      withDevice.connection {
    Severity: Minor
    Found in Sources/sdk-xyo-swift/Clients/XyoBleClient.swift - About 1 hr to fix

      Function doBoundWitness has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public func doBoundWitness (transfer: XyoIterableStructure?, completion : @escaping (_: XyoError?)->()?) {
        do {
            if (cycles >= XyoZigZagBoundWitnessSession.maxNumberOfCycles) {
                completion(XyoError.UNKNOWN_ERROR)
                return
      Severity: Minor
      Found in Carthage/Checkouts/sdk-core-swift/sdk-core-swift/boundWitness/XyoZigZagBoundWitnessSession.swift - About 1 hr to fix

        Function doBoundWitness has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public func doBoundWitness (transfer: XyoIterableStructure?, completion : @escaping (_: XyoError?)->()?) {
        do {
            if (cycles >= XyoZigZagBoundWitnessSession.maxNumberOfCycles) {
                completion(XyoError.UNKNOWN_ERROR)
                return
        Severity: Minor
        Found in Carthage/Checkouts/sdk-core-swift/Sources/sdk-core-swift/boundWitness/XyoZigZagBoundWitnessSession.swift - About 1 hr to fix

          Function bridge has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            func bridge() throws {
    guard semaphore == true, knownBridges.count > 0 else {
      if knownBridges.count == 0 {
        print("No known bridges")
      }
          Severity: Minor
          Found in Source/Clients/XyoTcpipClient.swift - About 1 hr to fix

            Function bridge has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              func bridge() throws {
    guard semaphore == true, knownBridges.count > 0 else {
      if knownBridges.count == 0 {
        print("No known bridges")
      }
            Severity: Minor
            Found in Sources/sdk-xyo-swift/Clients/XyoTcpipClient.swift - About 1 hr to fix

              Function peripheral has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  func peripheral(_ peripheral: CBPeripheral, didUpdateValueFor characteristic: CBCharacteristic, error: Error?) {
        operationsQueue.async {
            guard self.status != .disconnected || self.status != .timedOut else { return }

            guard error == nil else {
              Severity: Minor
              Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Gatt/GattRequest.swift - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getHumanHeuristics has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                public static func getHumanHeuristics(boundWitness: XyoBoundWitness) -> [String: String] {
      do {
          var returnArray: [String: String] = [:]
          guard let numberOfParties = try boundWitness.getNumberOfParties() else {
              return [:]
              Severity: Minor
              Found in Source/Heuristics/XyoHumanHeuristics.swift - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function peripheral has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                  func peripheral(_ peripheral: CBPeripheral, didUpdateValueFor characteristic: CBCharacteristic, error: Error?) {
        operationsQueue.async {
            guard self.status != .disconnected || self.status != .timedOut else { return }

            guard error == nil else {
              Severity: Minor
              Found in Carthage/Checkouts/sdk-ble-swift/Source/Gatt/GattRequest.swift - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function getHumanHeuristics has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                public static func getHumanHeuristics(boundWitness: XyoBoundWitness) -> [String: String] {
      do {
          var returnArray: [String: String] = [:]
          guard let numberOfParties = try boundWitness.getNumberOfParties() else {
              return [:]
              Severity: Minor
              Found in Sources/sdk-xyo-swift/Heuristics/XyoHumanHeuristics.swift - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function boundWitness has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public func boundWitness (handler : XyoNetworkHandler,
                              procedureCatalogue: XyoProcedureCatalog,
                              completion: @escaping (_: XyoBoundWitness?, _: XyoError?)->()) {
        
        if (currentBoundWitnessSession != nil) {
              Severity: Minor
              Found in Carthage/Checkouts/sdk-core-swift/Sources/sdk-core-swift/node/XyoOriginChainCreator.swift - About 1 hr to fix

                Function boundWitness has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public func boundWitness (handler : XyoNetworkHandler,
                              procedureCatalogue: XyoProcedureCatalog,
                              completion: @escaping (_: XyoBoundWitness?, _: XyoError?)->()) {
        
        if (currentBoundWitnessSession != nil) {
                Severity: Minor
                Found in Carthage/Checkouts/sdk-core-swift/sdk-core-swift/node/XyoOriginChainCreator.swift - About 1 hr to fix

                  Function getValues has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      func getValues() {
        guard let device = self.device else { return }
        self.characteristicValues.removeAll()
        var values = [XYBluetoothResult]()
        self.gattSpinner.startAnimation(self)
                  Severity: Minor
                  Found in Carthage/Checkouts/sdk-ble-swift/SampleMacOS/SampleMacOS/DetailViewController.swift - About 1 hr to fix

                    Function testPromiseAllHeterogeneous4Reject has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      func testPromiseAllHeterogeneous4Reject() {
    // Arrange.
    let promise1 = Promise { fulfill, _ in
      Test.delay(0.1) {
        fulfill(42)
                    Severity: Minor
                    Found in Carthage/Checkouts/promises/Tests/PromisesTests/Promise+AllTests.swift - About 1 hr to fix

                      Function testPromiseRetryNoDeallocUntilResolved has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        func testPromiseRetryNoDeallocUntilResolved() {
    // Arrange.
    weak var weakExtendedPromise1: Promise<Int>?
    weak var weakExtendedPromise2: Promise<Int>?
    let customAttempts = 3
                      Severity: Minor
                      Found in Carthage/Checkouts/promises/Tests/PromisesTests/Promise+RetryTests.swift - About 1 hr to fix

                        Function build has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                          public func build() throws -> XyoNode {
    if (XyoSdk.nodes.count > 0) {
      throw XyoNodeBuilderError(kind: .alreadyNodes)
    }
    if (self.storage == nil) {
                        Severity: Minor
                        Found in Source/sdk/XyoNodeBuilder.swift - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function doBoundWitness has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                        Open

                          func doBoundWitness(withDevice: XyoBluetoothDevice, withCompletion: BoundWitnessCallback) throws {
    
      self.delegate?.boundWitness(started: withDevice.id)

      withDevice.connection {
                        Severity: Minor
                        Found in Source/Clients/XyoBleClient.swift - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language