Sign upLogin

XYOracleNetwork/sdk-xyo-swift

View on GitHub
Star

Showing 485 of 674 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation

// copied and modified from https://github.com/CityOfZion/neo-swift/blob/master/NeoSwift/Models/Marketplace/Base58.swift
struct XyoBase58 {
    static let base58Alphabet = "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz"
Severity: Major
Found in Carthage/Checkouts/sdk-core-swift/sdk-core-swift/objectmodel/XyoBase58.swift and 1 other location - About 6 hrs to fix
Carthage/Checkouts/sdk-core-swift/Sources/sdk-core-swift/objectmodel/XyoBase58.swift on lines 9..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 418.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation

// copied and modified from https://github.com/CityOfZion/neo-swift/blob/master/NeoSwift/Models/Marketplace/Base58.swift
struct XyoBase58 {
    static let base58Alphabet = "123456789ABCDEFGHJKLMNPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz"
Severity: Major
Found in Carthage/Checkouts/sdk-core-swift/Sources/sdk-core-swift/objectmodel/XyoBase58.swift and 1 other location - About 6 hrs to fix
Carthage/Checkouts/sdk-core-swift/sdk-core-swift/objectmodel/XyoBase58.swift on lines 9..68

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 418.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import XyBleSdk
import CoreLocation
import CoreBluetooth
import Promises
Severity: Major
Found in Sources/sdk-xyo-swift/BleInterface/XyoBluetoothServer.swift and 1 other location - About 6 hrs to fix
Source/BleInterface/XyoBluetoothServer.swift on lines 8..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 417.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import XyBleSdk
import CoreLocation
import CoreBluetooth
import Promises
Severity: Major
Found in Source/BleInterface/XyoBluetoothServer.swift and 1 other location - About 6 hrs to fix
Sources/sdk-xyo-swift/BleInterface/XyoBluetoothServer.swift on lines 8..83

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 417.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import CoreBluetooth

public enum DeviceInformationService: String, XYServiceCharacteristic {

    public var serviceDisplayName: String { return "Device Information" }
Severity: Major
Found in Carthage/Checkouts/sdk-ble-swift/Source/Gatt/Standard/DeviceInformationService.swift and 1 other location - About 6 hrs to fix
Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Gatt/Standard/DeviceInformationService.swift on lines 9..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 403.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import CoreBluetooth

public enum DeviceInformationService: String, XYServiceCharacteristic {

    public var serviceDisplayName: String { return "Device Information" }
Severity: Major
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Gatt/Standard/DeviceInformationService.swift and 1 other location - About 6 hrs to fix
Carthage/Checkouts/sdk-ble-swift/Source/Gatt/Standard/DeviceInformationService.swift on lines 9..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 403.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation

public class XyoTcpSocketPipe: XyoNetworkPipe {
    private let socket : XyoTcpSocket
    private let initiationData : [UInt8]?
Severity: Major
Found in Carthage/Checkouts/sdk-core-swift/Sources/sdk-core-swift/network/tcp/XyoTcpSocketPipe.swift and 1 other location - About 6 hrs to fix
Carthage/Checkouts/sdk-core-swift/sdk-core-swift/network/tcp/XyoTcpSocketPipe.swift on lines 9..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 398.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation

public class XyoTcpSocketPipe: XyoNetworkPipe {
    private let socket : XyoTcpSocket
    private let initiationData : [UInt8]?
Severity: Major
Found in Carthage/Checkouts/sdk-core-swift/sdk-core-swift/network/tcp/XyoTcpSocketPipe.swift and 1 other location - About 6 hrs to fix
Carthage/Checkouts/sdk-core-swift/Sources/sdk-core-swift/network/tcp/XyoTcpSocketPipe.swift on lines 9..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 398.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import CoreBluetooth

public enum BasicConfigService: String, XYServiceCharacteristic {

    public var serviceDisplayName: String { return "Basic Config" }
Severity: Major
Found in Carthage/Checkouts/sdk-ble-swift/Source/Gatt/xy3/BasicConfigService.swift and 1 other location - About 6 hrs to fix
Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Gatt/xy3/BasicConfigService.swift on lines 9..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 387.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import CoreBluetooth

public enum BasicConfigService: String, XYServiceCharacteristic {

    public var serviceDisplayName: String { return "Basic Config" }
Severity: Major
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Gatt/xy3/BasicConfigService.swift and 1 other location - About 6 hrs to fix
Carthage/Checkouts/sdk-ble-swift/Source/Gatt/xy3/BasicConfigService.swift on lines 9..70

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 387.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import CoreBluetooth

// The XY2-specific implementation
public class XY2BluetoothDevice: XYFinderDeviceBase {
    public static let family = XYDeviceFamily.init(uuid: UUID(uuidString: XY2BluetoothDevice.uuid)!,
Severity: Major
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Devices/XY2BluetoothDevice.swift and 1 other location - About 5 hrs to fix
Carthage/Checkouts/sdk-ble-swift/Source/Devices/XY2BluetoothDevice.swift on lines 9..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 367.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import CoreBluetooth

// The XY2-specific implementation
public class XY2BluetoothDevice: XYFinderDeviceBase {
    public static let family = XYDeviceFamily.init(uuid: UUID(uuidString: XY2BluetoothDevice.uuid)!,
Severity: Major
Found in Carthage/Checkouts/sdk-ble-swift/Source/Devices/XY2BluetoothDevice.swift and 1 other location - About 5 hrs to fix
Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Devices/XY2BluetoothDevice.swift on lines 9..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 367.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import sdk_core_swift
import XyBleSdk
import CoreBluetooth
Severity: Major
Found in Sources/sdk-xyo-swift/BleInterface/devices/XyoDifferentiableDevice.swift and 1 other location - About 5 hrs to fix
Source/BleInterface/devices/XyoDifferentiableDevice.swift on lines 8..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 363.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import sdk_core_swift
import XyBleSdk
import CoreBluetooth
Severity: Major
Found in Source/BleInterface/devices/XyoDifferentiableDevice.swift and 1 other location - About 5 hrs to fix
Sources/sdk-xyo-swift/BleInterface/devices/XyoDifferentiableDevice.swift on lines 8..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 363.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

import Foundation
import sdk_core_swift
import XyBleSdk
import CoreBluetooth
Severity: Major
Found in Sources/sdk-xyo-swift/BleInterface/devices/bridgeX/XyoBridgeXService.swift and 5 other locations - About 5 hrs to fix
Source/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..64
Source/BleInterface/devices/bridgeX/XyoBridgeXService.swift on lines 8..64
Source/BleInterface/devices/iosX/XyoIosXService.swift on lines 9..65
Sources/sdk-xyo-swift/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..65
Sources/sdk-xyo-swift/BleInterface/devices/iosX/XyoIosXService.swift on lines 9..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 356.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

import Foundation
import XyBleSdk
import CoreBluetooth

public enum XyoIosXService : XYServiceCharacteristic {
Severity: Major
Found in Source/BleInterface/devices/iosX/XyoIosXService.swift and 5 other locations - About 5 hrs to fix
Source/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..64
Source/BleInterface/devices/bridgeX/XyoBridgeXService.swift on lines 8..64
Sources/sdk-xyo-swift/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..65
Sources/sdk-xyo-swift/BleInterface/devices/bridgeX/XyoBridgeXService.swift on lines 8..65
Sources/sdk-xyo-swift/BleInterface/devices/iosX/XyoIosXService.swift on lines 9..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 356.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

import Foundation
import sdk_core_swift
import XyBleSdk
import CoreBluetooth
Severity: Major
Found in Sources/sdk-xyo-swift/BleInterface/devices/iosX/XyoIosXService.swift and 5 other locations - About 5 hrs to fix
Source/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..64
Source/BleInterface/devices/bridgeX/XyoBridgeXService.swift on lines 8..64
Source/BleInterface/devices/iosX/XyoIosXService.swift on lines 9..65
Sources/sdk-xyo-swift/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..65
Sources/sdk-xyo-swift/BleInterface/devices/bridgeX/XyoBridgeXService.swift on lines 8..65

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 356.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import CoreBluetooth

open class XYMutableService {
    public var characteristics = [String : XYMutableCharacteristic]()
Severity: Major
Found in Carthage/Checkouts/sdk-ble-swift/Sources/XyBleSdk/Gatt/Peripheral/XYMutableService.swift and 1 other location - About 5 hrs to fix
Carthage/Checkouts/sdk-ble-swift/Source/Gatt/Peripheral/XYMutableService.swift on lines 8..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 356.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

import Foundation
import XyBleSdk
import CoreBluetooth

public enum XyoBridgeXService : XYServiceCharacteristic {
Severity: Major
Found in Source/BleInterface/devices/bridgeX/XyoBridgeXService.swift and 5 other locations - About 5 hrs to fix
Source/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..64
Source/BleInterface/devices/iosX/XyoIosXService.swift on lines 9..65
Sources/sdk-xyo-swift/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..65
Sources/sdk-xyo-swift/BleInterface/devices/bridgeX/XyoBridgeXService.swift on lines 8..65
Sources/sdk-xyo-swift/BleInterface/devices/iosX/XyoIosXService.swift on lines 9..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 356.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

import Foundation
import sdk_core_swift
import XyBleSdk
import CoreBluetooth
Severity: Major
Found in Sources/sdk-xyo-swift/BleInterface/devices/androidX/XyoAndroidXService.swift and 5 other locations - About 5 hrs to fix
Source/BleInterface/devices/androidX/XyoAndroidXService.swift on lines 8..64
Source/BleInterface/devices/bridgeX/XyoBridgeXService.swift on lines 8..64
Source/BleInterface/devices/iosX/XyoIosXService.swift on lines 9..65
Sources/sdk-xyo-swift/BleInterface/devices/bridgeX/XyoBridgeXService.swift on lines 8..65
Sources/sdk-xyo-swift/BleInterface/devices/iosX/XyoIosXService.swift on lines 9..66

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 356.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language