Sign upLogin

XingFramework/Relayer

View on GitHub
Star
dist/relayer/jsonpath.js

Summary

Maintainability
F
2 wks
Test Coverage

Function jsonPath has a Cognitive Complexity of 106 (exceeds 5 allowed). Consider refactoring.
Open

export default function jsonPath(obj, expr, arg) {
   var P = {
      resultType: arg && arg.resultType || "value",
      flatten: arg && arg.flatten || false,
      wrap: (arg && arg.hasOwnProperty('wrap')) ? arg.wrap : true,
Severity: Minor
Found in dist/relayer/jsonpath.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function jsonPath has 165 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function jsonPath(obj, expr, arg) {
   var P = {
      resultType: arg && arg.resultType || "value",
      flatten: arg && arg.flatten || false,
      wrap: (arg && arg.hasOwnProperty('wrap')) ? arg.wrap : true,
Severity: Major
Found in dist/relayer/jsonpath.js - About 6 hrs to fix

    Function trace has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          trace: function(expr, val, path) {
         function addRet(elems) { ret = ret.concat(elems); }
         // no expr to follow? return path and value as the result of this trace branch
         if (!expr.length){ return [{path: path, value: val}]; }
    Severity: Minor
    Found in dist/relayer/jsonpath.js - About 1 hr to fix

      Function walk has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            walk: function(loc, expr, val, path, f) {
      Severity: Minor
      Found in dist/relayer/jsonpath.js - About 35 mins to fix

        Avoid too many return statements within this function.
        Open

             return obj;
        Severity: Major
        Found in dist/relayer/jsonpath.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                 return result.reduce(function(result, ea) {
         var valOrPath = ea[resultType];
         // For our purposes we don't return paths but rather arrays of segments
         // if (resultType === 'path'){ valOrPath = P.asPath(valOrPath); }
         if (P.flatten && Array.isArray(valOrPath)) {
          Severity: Major
          Found in dist/relayer/jsonpath.js - About 30 mins to fix

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            export default function jsonPath(obj, expr, arg) {
   var P = {
      resultType: arg && arg.resultType || "value",
      flatten: arg && arg.flatten || false,
      wrap: (arg && arg.hasOwnProperty('wrap')) ? arg.wrap : true,
            Severity: Major
            Found in dist/relayer/jsonpath.js and 1 other location - About 1 wk to fix
            src/relayer/jsonpath.js on lines 18..200

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 2260.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

            if (!Array.isArray) {
  Array.isArray = function(vArg) {
    return Object.prototype.toString.call(vArg) === "[object Array]";
  };
}
            Severity: Major
            Found in dist/relayer/jsonpath.js and 1 other location - About 1 hr to fix
            src/relayer/jsonpath.js on lines 7..11

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status