Sign upLogin

XoopsModules25x/mylinks

View on GitHub
Star

Showing 98 of 370 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function MultiCell($w,$h,$txt,$border=0,$align='L',$fill=0)
{
  if($this->CurrentFont['type']=='Type0')
    $this->MBMultiCell($w,$h,$txt,$border,$align,$fill);
  else
Severity: Major
Found in fpdf/chinese.php and 2 other locations - About 1 hr to fix
fpdf/japanese.php on lines 100..106
fpdf/korean.php on lines 91..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function MultiCell($w,$h,$txt,$border=0,$align='L',$fill=0)
{
  if($this->CurrentFont['type']=='Type0')
    $this->SJISMultiCell($w,$h,$txt,$border,$align,$fill);
  else
Severity: Major
Found in fpdf/japanese.php and 2 other locations - About 1 hr to fix
fpdf/chinese.php on lines 121..127
fpdf/korean.php on lines 91..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 101.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

if ($pdf_data['subsubtitle'] <> '') {
    $pdf->WriteHTML($puff, $pdf_config['scale']);
    $pdf->SetFont($pdf_config['font']['subsubtitle']['family'], $pdf_config['font']['subsubtitle']['style'], $pdf_config['font']['subsubtitle']['size']);
    $pdf->WriteHTML($pdf_data['subsubtitle'], $pdf_config['scale']);
}
Severity: Minor
Found in makepdf.php and 1 other location - About 1 hr to fix
makepdf.php on lines 117..121

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

if ($pdf_data['subtitle'] <> '') {
    $pdf->WriteHTML($puff, $pdf_config['scale']);
    $pdf->SetFont($pdf_config['font']['subtitle']['family'], $pdf_config['font']['subtitle']['style'], $pdf_config['font']['subtitle']['size']);
    $pdf->WriteHTML($pdf_data['subtitle'], $pdf_config['scale']);
}
Severity: Minor
Found in makepdf.php and 1 other location - About 1 hr to fix
makepdf.php on lines 122..126

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 100.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if(($r==0 && $g==0 && $b==0) || $g==-1)
    $this->TextColor=sprintf('%.3f g',$r/255);
  else
    $this->TextColor=sprintf('%.3f %.3f %.3f rg',$r/255,$g/255,$b/255);
Severity: Major
Found in fpdf/fpdf.php and 2 other locations - About 55 mins to fix
fpdf/fpdf.php on lines 397..400
fpdf/fpdf.php on lines 408..411

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if(($r==0 && $g==0 && $b==0) || $g==-1)
    $this->FillColor=sprintf('%.3f g',$r/255);
  else
    $this->FillColor=sprintf('%.3f %.3f %.3f rg',$r/255,$g/255,$b/255);
Severity: Major
Found in fpdf/fpdf.php and 2 other locations - About 55 mins to fix
fpdf/fpdf.php on lines 397..400
fpdf/fpdf.php on lines 420..423

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function AddBig5hwFont($family='PMingLiU',$name='MSungStd-Light-Acro')
{
  //Add Big5 font with half-witdh Latin
  for($i=32;$i<=126;$i++)
    $cw[chr($i)]=500;
Severity: Major
Found in fpdf/chinese.php and 2 other locations - About 55 mins to fix
fpdf/chinese.php on lines 78..86
fpdf/korean.php on lines 48..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function AddGBhwFont($family='GB-hw',$name='STSongStd-Light-Acro')
{
  //Add GB font with half-width Latin
  for($i=32;$i<=126;$i++)
    $cw[chr($i)]=500;
Severity: Major
Found in fpdf/chinese.php and 2 other locations - About 55 mins to fix
fpdf/chinese.php on lines 59..67
fpdf/korean.php on lines 48..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  if(($r==0 && $g==0 && $b==0) || $g==-1)
    $this->DrawColor=sprintf('%.3f G',$r/255);
  else
    $this->DrawColor=sprintf('%.3f %.3f %.3f RG',$r/255,$g/255,$b/255);
Severity: Major
Found in fpdf/fpdf.php and 2 other locations - About 55 mins to fix
fpdf/fpdf.php on lines 408..411
fpdf/fpdf.php on lines 420..423

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

function AddUHChwFont($family='UHC-hw',$name='HYSMyeongJoStd-Medium-Acro')
{
  //Add UHC font with half-witdh Latin
  for($i=32;$i<=126;$i++)
    $cw[chr($i)]=500;
Severity: Major
Found in fpdf/korean.php and 2 other locations - About 55 mins to fix
fpdf/chinese.php on lines 59..67
fpdf/chinese.php on lines 78..86

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 98.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (mlelestyle.display == "block") {
        mlelestyle.display = "none";
         mlimgele.src = targeturl+'/restore.gif';
         mlimgele.alt = 'Click me if you want to restore this block';
         mlimgele.title = 'Click me if you want to restore this block';
Severity: Minor
Found in include/mylinks.js and 1 other location - About 50 mins to fix
include/mylinks.js on lines 11..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      else {
        mlelestyle.display = "block";
         mlimgele.src = targeturl+'/minimize.gif';
         mlimgele.alt = 'Click me if you want to minimize this block';
         mlimgele.title = 'Click me if you want to minimize this block';
Severity: Minor
Found in include/mylinks.js and 1 other location - About 50 mins to fix
include/mylinks.js on lines 5..10

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ($options[1] == 1) {
            $block['users'][$i]['avatar'] = $newmembers[$i]->getVar('user_avatar') != 'blank.gif' ? XOOPS_UPLOAD_URL . '/' . $newmembers[$i]->getVar('user_avatar') : '';
        } else {
            $block['users'][$i]['avatar'] = '';
        }
Severity: Minor
Found in extras/XOOPS_2.5.x/htdocs/modules/system/blocks/system_blocks.php and 1 other location - About 45 mins to fix
extras/XOOPS_2.5.x/htdocs/modules/system/blocks/system_blocks.php on lines 419..423

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if ($options[1] == 1) {
            $block['users'][$i]['avatar'] = $topposters[$i]->getVar('user_avatar') != 'blank.gif' ? XOOPS_UPLOAD_URL . '/' . $topposters[$i]->getVar('user_avatar') : '';
        } else {
            $block['users'][$i]['avatar'] = '';
        }
Severity: Minor
Found in extras/XOOPS_2.5.x/htdocs/modules/system/blocks/system_blocks.php and 1 other location - About 45 mins to fix
extras/XOOPS_2.5.x/htdocs/modules/system/blocks/system_blocks.php on lines 385..389

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    case 12://    FC2 Bookmark Dot ID: 12
      var AddSite = "http://bookmark.fc2.com/user/post?";
      var AddUrlVar = "url";
      var AddTitleVar = "title";
      var AddNoteVar = "";
Severity: Major
Found in include/addto-multi.js and 23 other locations - About 40 mins to fix
include/addto-multi.js on lines 74..81
include/addto-multi.js on lines 82..89
include/addto-multi.js on lines 90..97
include/addto-multi.js on lines 98..105
include/addto-multi.js on lines 106..113
include/addto-multi.js on lines 114..121
include/addto-multi.js on lines 122..129
include/addto-multi.js on lines 130..137
include/addto-multi.js on lines 138..145
include/addto-multi.js on lines 146..153
include/addto-multi.js on lines 154..161
include/addto-multi.js on lines 162..169
include/addto-multi.js on lines 178..185
include/addto-multi.js on lines 186..193
include/addto-multi.js on lines 194..201
include/addto-multi.js on lines 202..209
include/addto-multi.js on lines 210..217
include/addto-multi.js on lines 218..225
include/addto-multi.js on lines 226..233
include/addto-multi.js on lines 234..241
include/addto-multi.js on lines 242..249
include/addto-multi.js on lines 250..257
include/addto-multi.js on lines 258..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    case 18://    Newsvine Dot ID: 18
      var AddSite = "http://www.newsvine.com/_wine/save?";
      var AddUrlVar = "u";
      var AddTitleVar = "h";
      var AddNoteVar = "";
Severity: Major
Found in include/addto-multi.js and 23 other locations - About 40 mins to fix
include/addto-multi.js on lines 74..81
include/addto-multi.js on lines 82..89
include/addto-multi.js on lines 90..97
include/addto-multi.js on lines 98..105
include/addto-multi.js on lines 106..113
include/addto-multi.js on lines 114..121
include/addto-multi.js on lines 122..129
include/addto-multi.js on lines 130..137
include/addto-multi.js on lines 138..145
include/addto-multi.js on lines 146..153
include/addto-multi.js on lines 154..161
include/addto-multi.js on lines 162..169
include/addto-multi.js on lines 170..177
include/addto-multi.js on lines 178..185
include/addto-multi.js on lines 186..193
include/addto-multi.js on lines 194..201
include/addto-multi.js on lines 202..209
include/addto-multi.js on lines 210..217
include/addto-multi.js on lines 226..233
include/addto-multi.js on lines 234..241
include/addto-multi.js on lines 242..249
include/addto-multi.js on lines 250..257
include/addto-multi.js on lines 258..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    case 11://    Bookmarktracker Dot ID: 11
      var AddSite = "http://www.bookmarktracker.com/frame_add.cfm?";
      var AddUrlVar = "url";
      var AddTitleVar = "title";
      var AddNoteVar = "";
Severity: Major
Found in include/addto-multi.js and 23 other locations - About 40 mins to fix
include/addto-multi.js on lines 74..81
include/addto-multi.js on lines 82..89
include/addto-multi.js on lines 90..97
include/addto-multi.js on lines 98..105
include/addto-multi.js on lines 106..113
include/addto-multi.js on lines 114..121
include/addto-multi.js on lines 122..129
include/addto-multi.js on lines 130..137
include/addto-multi.js on lines 138..145
include/addto-multi.js on lines 146..153
include/addto-multi.js on lines 154..161
include/addto-multi.js on lines 170..177
include/addto-multi.js on lines 178..185
include/addto-multi.js on lines 186..193
include/addto-multi.js on lines 194..201
include/addto-multi.js on lines 202..209
include/addto-multi.js on lines 210..217
include/addto-multi.js on lines 218..225
include/addto-multi.js on lines 226..233
include/addto-multi.js on lines 234..241
include/addto-multi.js on lines 242..249
include/addto-multi.js on lines 250..257
include/addto-multi.js on lines 258..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    case 10://    Blogmarks Dot ID: 10
      var AddSite = "http://blogmarks.net/my/new.php?";
      var AddUrlVar = "url";
      var AddTitleVar = "title";
      var AddNoteVar = "";
Severity: Major
Found in include/addto-multi.js and 23 other locations - About 40 mins to fix
include/addto-multi.js on lines 74..81
include/addto-multi.js on lines 82..89
include/addto-multi.js on lines 90..97
include/addto-multi.js on lines 98..105
include/addto-multi.js on lines 106..113
include/addto-multi.js on lines 114..121
include/addto-multi.js on lines 122..129
include/addto-multi.js on lines 130..137
include/addto-multi.js on lines 138..145
include/addto-multi.js on lines 146..153
include/addto-multi.js on lines 162..169
include/addto-multi.js on lines 170..177
include/addto-multi.js on lines 178..185
include/addto-multi.js on lines 186..193
include/addto-multi.js on lines 194..201
include/addto-multi.js on lines 202..209
include/addto-multi.js on lines 210..217
include/addto-multi.js on lines 218..225
include/addto-multi.js on lines 226..233
include/addto-multi.js on lines 234..241
include/addto-multi.js on lines 242..249
include/addto-multi.js on lines 250..257
include/addto-multi.js on lines 258..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    case 17://    Nifty Clip Dot ID: 17
      var AddSite = "http://clip.nifty.com/create?";
      var AddUrlVar = "url";
      var AddTitleVar = "title";
      var AddNoteVar = "";
Severity: Major
Found in include/addto-multi.js and 23 other locations - About 40 mins to fix
include/addto-multi.js on lines 74..81
include/addto-multi.js on lines 82..89
include/addto-multi.js on lines 90..97
include/addto-multi.js on lines 98..105
include/addto-multi.js on lines 106..113
include/addto-multi.js on lines 114..121
include/addto-multi.js on lines 122..129
include/addto-multi.js on lines 130..137
include/addto-multi.js on lines 138..145
include/addto-multi.js on lines 146..153
include/addto-multi.js on lines 154..161
include/addto-multi.js on lines 162..169
include/addto-multi.js on lines 170..177
include/addto-multi.js on lines 178..185
include/addto-multi.js on lines 186..193
include/addto-multi.js on lines 194..201
include/addto-multi.js on lines 202..209
include/addto-multi.js on lines 218..225
include/addto-multi.js on lines 226..233
include/addto-multi.js on lines 234..241
include/addto-multi.js on lines 242..249
include/addto-multi.js on lines 250..257
include/addto-multi.js on lines 258..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 24 locations. Consider refactoring.
Open

    case 2:    //    Del.icio.us    ID:2 &v=3&noui=yes&jump=close
      var AddSite = "http://del.icio.us/post?";
      var AddUrlVar = "url";
      var AddTitleVar = "title";
      var AddNoteVar = "";
Severity: Major
Found in include/addto-multi.js and 23 other locations - About 40 mins to fix
include/addto-multi.js on lines 74..81
include/addto-multi.js on lines 82..89
include/addto-multi.js on lines 98..105
include/addto-multi.js on lines 106..113
include/addto-multi.js on lines 114..121
include/addto-multi.js on lines 122..129
include/addto-multi.js on lines 130..137
include/addto-multi.js on lines 138..145
include/addto-multi.js on lines 146..153
include/addto-multi.js on lines 154..161
include/addto-multi.js on lines 162..169
include/addto-multi.js on lines 170..177
include/addto-multi.js on lines 178..185
include/addto-multi.js on lines 186..193
include/addto-multi.js on lines 194..201
include/addto-multi.js on lines 202..209
include/addto-multi.js on lines 210..217
include/addto-multi.js on lines 218..225
include/addto-multi.js on lines 226..233
include/addto-multi.js on lines 234..241
include/addto-multi.js on lines 242..249
include/addto-multi.js on lines 250..257
include/addto-multi.js on lines 258..265

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language