XoopsModules25x/smallworld

File jquery.bookmark.js has 482 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/* http://keith-wood.name/bookmark.html
    Sharing bookmarks for jQuery v1.4.0.
    Written by Keith Wood (kbwood{at}iinet.com.au) March 2008.
    Dual licensed under the GPL (http://dev.jquery.com/browser/trunk/jquery/GPL-LICENSE.txt) and 
    MIT (http://dev.jquery.com/browser/trunk/jquery/MIT-LICENSE.txt) licenses. 

Function uaMatch has 105 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  function uaMatch( ua ) {
    // If an UA is not provided, default to the current browser UA.
    if ( ua === undefined ) {
      ua = window.navigator.userAgent;
    }

Function Bookmark has 94 lines of code (exceeds 25 allowed). Consider refactoring.

Open

function Bookmark() {
    this._defaults = {
        url: '',    // The URL to bookmark, leave blank for the current page
        sourceTag: '', // Extra tag to add to URL to indicate source when it returns
        title: '',    // The title to bookmark, leave blank for the current one

Function _updateBookmark has 75 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _updateBookmark: function(target, settings) {
        var oldSettings = $.data(target[0], PROP_NAME) || $.extend({}, this._defaults);
        settings = extendRemove(oldSettings, settings || {});
        $.data(target[0], PROP_NAME, settings);
        var sites = settings.sites;

Consider simplifying this complex logical expression.

Open

    if ( browser.android || browser.bb || browser.blackberry || browser.ipad || browser.iphone ||
      browser.ipod || browser.kindle || browser.playbook || browser.silk || browser[ "windows phone" ]) {
      browser.mobile = true;
    }

Function _addOneSite has 32 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    _addOneSite: function(settings, list, display, icon, url, onclick, hint) {
        var hintFormat = settings.hint || '{s}';
        var html = '<li><a href="' + url + '"' +
            (settings.target ? ' target="' + settings.target + '"' : '') + '>';
        if (icon !== null) {

Function _addOneSite has 7 arguments (exceeds 4 allowed). Consider refactoring.

Open

    _addOneSite: function(settings, list, display, icon, url, onclick, hint) {

Function addSite has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    addSite: function(id, display, icon, lang, category, url) {

Consider simplifying this complex logical expression.

Open

            if (typeof icon === 'number') {
                html += '<span title="' + title + '" ' +
                    (settings.iconsStyle ? 'class="' + settings.iconsStyle + '" ' : '') +
                    'style="' + (settings.iconsStyle ? 'background-position: ' :
                    'background: transparent url(' + settings.icons + ') no-repeat ') + '-' +

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    var platform_match = /(ipad)/.exec( ua ) ||
        /(ipod)/.exec( ua ) ||
        /(windows phone)/.exec( ua ) ||
        /(iphone)/.exec( ua ) ||
        /(kindle)/.exec( ua ) ||

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    var match = /(edge)\/([\w.]+)/.exec( ua ) ||
        /(opr)[\/]([\w.]+)/.exec( ua ) ||
        /(chrome)[ \/]([\w.]+)/.exec( ua ) ||
        /(iemobile)[\/]([\w.]+)/.exec( ua ) ||
        /(version)(applewebkit)[ \/]([\w.]+).*(safari)[ \/]([\w.]+)/.exec( ua ) ||

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if (lang) {
                    $.each($.bookmark._sites, function(id, site) {
                        if (site.lang === lang[1] && $.inArray(id, sites) === -1) {
                            sites.push(id);
                        }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if (category) {
                    $.each($.bookmark._sites, function(id, site) {
                        if (site.category === category[1] && $.inArray(id, sites) === -1) {
                            sites.push(id);
                        }

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    if ( browser.safari && browser.silk ) {
      var silk = "silk";

      matched.browser = silk;
      browser[silk] = true;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    if ( browser.rv || browser.iemobile) {
      var ie = "msie";

      matched.browser = ie;
      browser[ie] = true;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    if ( browser.safari && browser.blackberry ) {
      var blackberry = "blackberry";

      matched.browser = blackberry;
      browser[blackberry] = true;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    if ( browser.safari && browser.kindle ) {
      var kindle = "kindle";

      matched.browser = kindle;
      browser[kindle] = true;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    if ( browser.safari && browser.android ) {
      var android = "android";

      matched.browser = android;
      browser[android] = true;

• Read up
  Read up

Similar blocks of code found in 6 locations. Consider refactoring.

Open

    if ( browser.safari && browser.playbook ) {
      var playbook = "playbook";

      matched.browser = playbook;
      browser[playbook] = true;

• Read up
  Read up