Sign upLogin

XoopsModules25x/userlog

View on GitHub
Star
assets/js/scripts.js

Summary

Maintainability
D
2 days
Test Coverage

Function validate has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

function validate(elName, elType, prevent, disablecat, elMsg) {
    var i = 0;
    var el = document.getElementsByName(elName);
    var is_valid = true;
    switch (elType) {
Severity: Minor
Found in assets/js/scripts.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function validate(elName, elType, prevent, disablecat, elMsg) {
    var i = 0;
    var el = document.getElementsByName(elName);
    var is_valid = true;
    switch (elType) {
Severity: Major
Found in assets/js/scripts.js - About 2 hrs to fix

    Function ToggleBlock has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    function ToggleBlock(blockid, icon, src_expand, src_collapse, alt_expand, alt_collapse, class_expand, class_collapse) {
    Severity: Major
    Found in assets/js/scripts.js - About 1 hr to fix

      Function SaveCollapsed has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function SaveCollapsed(objid, addcollapsed) {
    var collapsed = GetCookie(toggle_cookie);
    var tmp = "";
    if (collapsed != null) {
        collapsed = collapsed.split(",");
      Severity: Minor
      Found in assets/js/scripts.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function GetCookie has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      function GetCookie(name) {
    cookie_name = name + "=";
    cookie_length = document.cookie.length;
    cookie_begin = 0;
    while (cookie_begin < cookie_length) {
      Severity: Minor
      Found in assets/js/scripts.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                              if (el.options[i].value != '') {
                            el.value = el.options[i].value;
                            break; // loop exit
                        }
      Severity: Major
      Found in assets/js/scripts.js - About 45 mins to fix

        Function validate has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function validate(elName, elType, prevent, disablecat, elMsg) {
        Severity: Minor
        Found in assets/js/scripts.js - About 35 mins to fix

          Function ToggleBlock has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          function ToggleBlock(blockid, icon, src_expand, src_collapse, alt_expand, alt_collapse, class_expand, class_collapse) {
    var Img_tag = 'IMG';
    var el = document.getElementById(blockid);
    if (el.className == class_expand) {
        el.className = class_collapse;
          Severity: Minor
          Found in assets/js/scripts.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function preventSubmitEmptyInput has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          function preventSubmitEmptyInput($prefix) {
    var eles = [];
    var inputs = document.getElementsByTagName("input");
    for (var i = 0; i < inputs.length; i++) {
        if (inputs[i].name.indexOf($prefix) == 0) {
          Severity: Minor
          Found in assets/js/scripts.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (el.className == class_expand) {
        el.className = class_collapse;
        if (icon.nodeName == Img_tag) {
            icon.src = src_collapse;
        }
          Severity: Major
          Found in assets/js/scripts.js and 1 other location - About 1 hr to fix
          assets/js/scripts.js on lines 44..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              else {
        el.className = class_expand;
        if (icon.nodeName == Img_tag) {
            icon.src = src_expand;
        }
          Severity: Major
          Found in assets/js/scripts.js and 1 other location - About 1 hr to fix
          assets/js/scripts.js on lines 35..43

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status