Sign upLogin

YassinAJDI/MaterialJournal

View on GitHub
Star

Showing 2 of 8 total issues

Method onBindViewHolder has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @Override
    public void onBindViewHolder(@NonNull RecyclerView.ViewHolder holder, int position) {
        final Note note = mNotes.get(position);
        Timber.d(note.toString());
Severity: Major
Found in app/src/main/java/com/ajdi/yassin/materialjournal/ui/notes/NotesAdapter.java - About 2 hrs to fix

    Method handleSignInResponse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @MainThread
    private void handleSignInResponse(int resultCode, Intent data) {
        final IdpResponse response = IdpResponse.fromResultIntent(data);

        // Successfully signed in
    Severity: Minor
    Found in app/src/main/java/com/ajdi/yassin/materialjournal/ui/login/AuthUiActivity.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language