Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Contacts/resources/Detail.js

Summary

Maintainability
D
3 days
Test Coverage

Function registerRecordPreSaveEvent has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        registerRecordPreSaveEvent: function (form) {
            var primaryEmailField = jQuery('[name="email"]');
            if (typeof form === 'undefined') {
                form = this.getForm();
            }
Severity: Minor
Found in public_html/layouts/basic/modules/Contacts/resources/Detail.js - About 1 hr to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

            registerShowHierarchy: function () {
            let thisInstance = this,
                hierarchyButton = $('.detailViewTitle'),
                params = {
                    module: app.getModuleName(),
    Severity: Major
    Found in public_html/layouts/basic/modules/Contacts/resources/Detail.js and 2 other locations - About 6 hrs to fix
    public_html/layouts/basic/modules/HelpDesk/resources/Detail.js on lines 106..126
    public_html/layouts/basic/modules/Project/resources/Detail.js on lines 115..135

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 166.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            displayHierarchyResponseData: function (data) {
            let callbackFunction = function () {
                app.showScrollBar($('#hierarchyScroll'), {
                    height: '300px',
                    railVisible: true,
    Severity: Major
    Found in public_html/layouts/basic/modules/Contacts/resources/Detail.js and 3 other locations - About 5 hrs to fix
    public_html/layouts/basic/modules/Accounts/resources/Detail.js on lines 41..55
    public_html/layouts/basic/modules/Competition/resources/Detail.js on lines 24..38
    public_html/layouts/basic/modules/Project/resources/Detail.js on lines 78..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 138.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            getHierarchyResponseData: function (params) {
            let thisInstance = this,
                aDeferred = jQuery.Deferred();

            if (!$.isEmptyObject(thisInstance.hierarchyResponseCache)) {
    Severity: Major
    Found in public_html/layouts/basic/modules/Contacts/resources/Detail.js and 2 other locations - About 4 hrs to fix
    public_html/layouts/basic/modules/HelpDesk/resources/Detail.js on lines 50..62
    public_html/layouts/basic/modules/Project/resources/Detail.js on lines 61..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 133.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            registerHierarchyRecordCount: function () {
            let hierarchyButton = $('.js-detail-hierarchy'),
                params = {
                    module: app.getModuleName(),
                    action: 'RelationAjax',
    Severity: Major
    Found in public_html/layouts/basic/modules/Contacts/resources/Detail.js and 3 other locations - About 4 hrs to fix
    public_html/layouts/basic/modules/Competition/resources/Detail.js on lines 42..57
    public_html/layouts/basic/modules/HelpDesk/resources/Detail.js on lines 87..102
    public_html/layouts/basic/modules/Project/resources/Detail.js on lines 96..111

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 129.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if (primaryEmailField.length == 0) {
                        if (isAlertAlreadyShown <= 0) {
                            app.showNotify({
                                text: app.vtranslate('JS_PRIMARY_EMAIL_FIELD_DOES_NOT_EXISTS'),
                                type: 'error'
    Severity: Major
    Found in public_html/layouts/basic/modules/Contacts/resources/Detail.js and 1 other location - About 1 hr to fix
    public_html/layouts/basic/modules/Contacts/resources/Detail.js on lines 41..49

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        if (primaryEmailValue == '') {
                        if (isAlertAlreadyShown <= 0) {
                            app.showNotify({
                                text: app.vtranslate('JS_PLEASE_ENTER_PRIMARY_EMAIL_VALUE_TO_ENABLE_PORTAL_USER'),
                                type: 'info'
    Severity: Major
    Found in public_html/layouts/basic/modules/Contacts/resources/Detail.js and 1 other location - About 1 hr to fix
    public_html/layouts/basic/modules/Contacts/resources/Detail.js on lines 32..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 55.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status