Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Documents/resources/Edit.js

Summary

Maintainability
A
3 hrs
Test Coverage

Function registerFileLocationTypeChangeEvent has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        registerFileLocationTypeChangeEvent: function (container) {
            var thisInstance = this;
            container.on('change', 'select[name="filelocationtype"]', function (e) {
                var fileLocationTypeElement = container.find('[name="filelocationtype"]');
                var fileNameElement = container.find('[name="filename"]');
Severity: Minor
Found in public_html/layouts/basic/modules/Documents/resources/Edit.js - About 1 hr to fix

    Similar blocks of code found in 7 locations. Consider refactoring.
    Open

                AppConnector.request(params)
                .done(function (data) {
                    aDeferred.resolve(data);
                })
                .fail(function (textStatus, errorThrown) {
    Severity: Major
    Found in public_html/layouts/basic/modules/Documents/resources/Edit.js and 6 other locations - About 1 hr to fix
    public_html/layouts/basic/modules/Documents/resources/List.js on lines 79..85
    public_html/layouts/basic/modules/Settings/Currency/resources/Currency.js on lines 271..277
    public_html/layouts/basic/modules/Settings/MappedFields/resources/List.js on lines 102..108
    public_html/layouts/basic/modules/Settings/Menu/resources/Menu.js on lines 243..249
    public_html/layouts/basic/modules/Vtiger/resources/Detail.js on lines 927..934
    public_html/layouts/resources/app.js on lines 2534..2540

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status