Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/HelpDesk/resources/Detail.js

Summary

Maintainability
F
1 wk
Test Coverage

Function addTimeControl has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

        addTimeControl(params, callback = () => {}) {
            let aDeferred = jQuery.Deferred();
            let referenceModuleName = 'OSSTimeControl';
            let parentId = params.recordId;
            let parentModule = 'HelpDesk';
Severity: Minor
Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File Detail.js has 293 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* {[The file is published on the basis of YetiForce Public License 6.5 that can be found in the following directory: licenses/LicenseEN.txt or yetiforce.com]} */
'use strict';

Vtiger_Detail_Js(
    'HelpDesk_Detail_Js',
Severity: Minor
Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js - About 3 hrs to fix

    Function saveFieldValues has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            saveFieldValues: function (fieldDetailList) {
            const self = this;
            var aDeferred = jQuery.Deferred();
            const recordId = app.getRecordId();
            var data = {};
    Severity: Major
    Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js - About 2 hrs to fix

      Function addTimeControl has 65 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              addTimeControl(params, callback = () => {}) {
            let aDeferred = jQuery.Deferred();
            let referenceModuleName = 'OSSTimeControl';
            let parentId = params.recordId;
            let parentModule = 'HelpDesk';
      Severity: Major
      Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js - About 2 hrs to fix

        Function preQuickCreateSave has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                    let preQuickCreateSave = function (data) {
                let index, queryParam, queryParamComponents;
                let queryParameters = [];

                if (typeof fullFormUrl !== 'undefined' && fullFormUrl.indexOf('?') !== -1) {
        Severity: Minor
        Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      let preQuickCreateSave = function (data) {
                let index, queryParam, queryParamComponents;
                let queryParameters = [];

                if (typeof fullFormUrl !== 'undefined' && fullFormUrl.indexOf('?') !== -1) {
          Severity: Major
          Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js and 1 other location - About 2 days to fix
          public_html/layouts/basic/modules/HelpDesk/resources/Edit.js on lines 108..146

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 490.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (typeof fullFormUrl !== 'undefined' && fullFormUrl.indexOf('?') !== -1) {
                let urlSplit = fullFormUrl.split('?');
                let queryString = urlSplit[1];
                let queryParameters = queryString.split('&');
                for (let index = 0; index < queryParameters.length; index++) {
          Severity: Major
          Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js and 1 other location - About 6 hrs to fix
          public_html/layouts/basic/modules/HelpDesk/resources/Edit.js on lines 147..158

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 168.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 3 locations. Consider refactoring.
          Open

                  registerShowHierarchy: function () {
            let thisInstance = this,
                hierarchyButton = $('.detailViewTitle'),
                params = {
                    module: app.getModuleName(),
          Severity: Major
          Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js and 2 other locations - About 6 hrs to fix
          public_html/layouts/basic/modules/Contacts/resources/Detail.js on lines 114..134
          public_html/layouts/basic/modules/Project/resources/Detail.js on lines 115..135

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 166.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

                  getHierarchyResponseData: function (params) {
            let thisInstance = this,
                aDeferred = $.Deferred();
            if (!$.isEmptyObject(thisInstance.hierarchyResponseCache)) {
                aDeferred.resolve(thisInstance.hierarchyResponseCache);
          Severity: Major
          Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js and 2 other locations - About 4 hrs to fix
          public_html/layouts/basic/modules/Contacts/resources/Detail.js on lines 59..72
          public_html/layouts/basic/modules/Project/resources/Detail.js on lines 61..73

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 133.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  registerHierarchyRecordCount: function () {
            let hierarchyButton = $('.js-detail-hierarchy'),
                params = {
                    module: app.getModuleName(),
                    action: 'RelationAjax',
          Severity: Major
          Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js and 3 other locations - About 4 hrs to fix
          public_html/layouts/basic/modules/Competition/resources/Detail.js on lines 42..57
          public_html/layouts/basic/modules/Contacts/resources/Detail.js on lines 95..110
          public_html/layouts/basic/modules/Project/resources/Detail.js on lines 96..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 129.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                  registerEvents: function () {
            this._super();
            this.registerSetServiceContracts();
            this.registerHierarchyRecordCount();
            this.registerShowHierarchy();
          Severity: Major
          Found in public_html/layouts/basic/modules/HelpDesk/resources/Detail.js and 3 other locations - About 45 mins to fix
          public_html/layouts/basic/modules/Settings/Colors/resources/Index.js on lines 21..26
          public_html/layouts/basic/modules/Settings/LayoutEditor/resources/LayoutEditor.js on lines 2176..2181
          public_html/layouts/basic/modules/Vtiger/resources/dashboards/Widget.js on lines 2944..2949

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status