Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js

Summary

Maintainability
D
1 day
Test Coverage

File Iframe.js has 337 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* {[The file is published on the basis of YetiForce Public License 6.5 that can be found in the following directory: licenses/LicenseEN.txt or yetiforce.com]} */
'use strict';

window.MailIntegration_Iframe = {
    mailId: 0,
Severity: Minor
Found in public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js - About 4 hrs to fix

    MailIntegration_Iframe has 26 functions (exceeds 20 allowed). Consider refactoring.
    Open

    window.MailIntegration_Iframe = {
    mailId: 0,
    container: {},
    iframe: {},
    iframeWindow: {},
    Severity: Minor
    Found in public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js - About 3 hrs to fix

      Function fillNewRecordData has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          fillNewRecordData(moduleName) {
        const data = {
            email: this.mailItem.from.emailAddress,
            email1: this.mailItem.from.emailAddress,
            relationOperation: true,
      Severity: Minor
      Found in public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js - About 1 hr to fix

        Function fillNewRecordData has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            fillNewRecordData(moduleName) {
        const data = {
            email: this.mailItem.from.emailAddress,
            email1: this.mailItem.from.emailAddress,
            relationOperation: true,
        Severity: Minor
        Found in public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        this.mailItem.getAllInternetHeadersAsync((body) => {
                    if (body.status === 'succeeded') {
                        this.mailDetails.mailHeaders = body.value;
                        resolve(body);
                    } else {
        Severity: Major
        Found in public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js and 1 other location - About 1 hr to fix
        public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js on lines 312..319

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                        this.mailItem.body.getAsync(Office.CoercionType.Html, (body) => {
                    if (body.status === 'succeeded') {
                        this.mailDetails.mailBody = body.value;
                        resolve(body);
                    } else {
        Severity: Major
        Found in public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js and 1 other location - About 1 hr to fix
        public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js on lines 322..329

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.connector({
            module: 'MailIntegration',
            action: 'Mail',
            mode: 'deleteRelation',
            mailId: this.mailId,
        Severity: Minor
        Found in public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js and 1 other location - About 35 mins to fix
        public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js on lines 205..215

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                this.connector({
            module: 'MailIntegration',
            action: 'Mail',
            mode: 'addRelation',
            mailId: this.mailId,
        Severity: Minor
        Found in public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js and 1 other location - About 35 mins to fix
        public_html/layouts/basic/modules/MailIntegration/resources/Iframe.js on lines 92..102

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 47.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status