Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/OSSMail/resources/checkmails.js

Summary

Maintainability
C
1 day
Test Coverage

Function registerUserList has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function registerUserList() {
    var selectUsers = $('.js-header__btn--mail select');
    if (selectUsers.data('select2')) {
        selectUsers.select2('destroy');
    } else {
Severity: Major
Found in public_html/layouts/basic/modules/OSSMail/resources/checkmails.js - About 2 hrs to fix

    Function checkMails has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function checkMails(users, initial = false) {
    let reloadSelect = false;
    AppConnector.request({
        module: 'OSSMail',
        action: 'CheckMails',
    Severity: Minor
    Found in public_html/layouts/basic/modules/OSSMail/resources/checkmails.js - About 1 hr to fix

      Function registerUserList has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      function registerUserList() {
    var selectUsers = $('.js-header__btn--mail select');
    if (selectUsers.data('select2')) {
        selectUsers.select2('destroy');
    } else {
      Severity: Minor
      Found in public_html/layouts/basic/modules/OSSMail/resources/checkmails.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

                                  if (
                                initial === false &&
                                (this.tagName === 'SPAN' || this.selected) &&
                                ((prevVal < num && prevVal >= 0) || (!prevVal && num > 0))
                            ) {
      Severity: Major
      Found in public_html/layouts/basic/modules/OSSMail/resources/checkmails.js - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (element.data('nomail')) {
                const badge = document.createElement('span');
                badge.className = 'badge badge-danger ml-1';
                badge.innerText = element.data('nomail');
                main.appendChild(badge);
        Severity: Major
        Found in public_html/layouts/basic/modules/OSSMail/resources/checkmails.js and 1 other location - About 1 hr to fix
        public_html/layouts/basic/modules/OSSMail/resources/checkmails.js on lines 30..35

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                        if (element.data('nomail')) {
                    const badge = document.createElement('span');
                    badge.className = 'badge badge-danger ml-1';
                    badge.innerText = element.data('nomail');
                    main.appendChild(badge);
        Severity: Major
        Found in public_html/layouts/basic/modules/OSSMail/resources/checkmails.js and 1 other location - About 1 hr to fix
        public_html/layouts/basic/modules/OSSMail/resources/checkmails.js on lines 47..52

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 71.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function getUrlVars() {
    let vars = {};
    window.location.href.replace(/[?&]+([^=&]+)=([^&]*)/gi, function (m, key, value) {
        vars[key] = value;
    });
        Severity: Minor
        Found in public_html/layouts/basic/modules/OSSMail/resources/checkmails.js and 1 other location - About 55 mins to fix
        public_html/layouts/resources/app.js on lines 2509..2515

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status