Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Settings/Companies/resources/Edit.js

Summary

Maintainability
D
2 days
Test Coverage

Function registerRefreshStatus has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        registerRefreshStatus: function () {
            let form = this.getForm();
            form.find('.js-refresh-status').on('click', function () {
                const progressIndicator = $.progressIndicator({
                    blockInfo: { enabled: true }
Severity: Minor
Found in public_html/layouts/basic/modules/Settings/Companies/resources/Edit.js - About 1 hr to fix

    Function registerSubmitForm has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            registerSubmitForm: function () {
            let form = this.getForm();
            form.on('submit', function (e) {
                e.preventDefault();
                if (form.validationEngine('validate') === true) {
    Severity: Minor
    Found in public_html/layouts/basic/modules/Settings/Companies/resources/Edit.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  form.on('submit', function (e) {
                e.preventDefault();
                if (form.validationEngine('validate') === true) {
                    let formData = new FormData(form[0]);
                    let params = {
      Severity: Major
      Found in public_html/layouts/basic/modules/Settings/Companies/resources/Edit.js and 1 other location - About 1 day to fix
      public_html/layouts/basic/modules/Settings/Companies/resources/EditModal.js on lines 9..37

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 255.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  form.find('.js-refresh-status').on('click', function () {
                const progressIndicator = $.progressIndicator({
                    blockInfo: { enabled: true }
                });
                AppConnector.request({
      Severity: Major
      Found in public_html/layouts/basic/modules/Settings/Companies/resources/Edit.js and 1 other location - About 1 day to fix
      public_html/layouts/basic/modules/Settings/YetiForce/resources/Shop.js on lines 213..238

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 209.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status