Sign upLogin

YetiForceCompany/YetiForceCRM

View on GitHub
Star
public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js

Summary

Maintainability
C
1 day
Test Coverage

Function registerOnChangeEventOfTargetModule has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        registerOnChangeEventOfTargetModule: function () {
            var form = jQuery('#leadsMapping');
            form.on('change', 'select.accountsFields.select2,select.contactFields.select2', function (e, executeChange) {
                if (typeof executeChange === 'undefined') {
                    executeChange = true;
Severity: Major
Found in public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js - About 2 hrs to fix

    File LeadMapping.js has 260 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*+***********************************************************************************
 * The contents of this file are subject to the vtiger CRM Public License Version 1.0
 * ("License"); You may not use this file except in compliance with the License
 * The Original Code is:  vtiger CRM Open Source
 * The Initial Developer of the Original Code is vtiger.
    Severity: Minor
    Found in public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js - About 2 hrs to fix

      Function registerOnChangeEventForSourceModule has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              registerOnChangeEventForSourceModule: function () {
            var form = jQuery('#leadsMapping');
            form.on('change', '.leadsFields', function (e) {
                var element = jQuery(e.currentTarget);
                var container = jQuery(element.closest('tr'));
      Severity: Minor
      Found in public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js - About 1 hr to fix

        Function registerEventForFormSubmit has 48 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                registerEventForFormSubmit: function () {
            jQuery('#leadsMapping').on('submit', function (e) {
                e.preventDefault();
                var mappingDetails = jQuery(this).serializeFormData();
                var params = {
        Severity: Minor
        Found in public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          var accountFieldsBasedOnType = form
                    .find('.newMapping')
                    .find('.accountsFields')
                    .children()
                    .filter('[data-type="' + selectedDataType + '"]')
          Severity: Major
          Found in public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js and 1 other location - About 1 hr to fix
          public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js on lines 123..128

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          var contactFieldsBasedOnType = form
                    .find('.newMapping')
                    .find('.contactFields')
                    .children()
                    .filter('option[data-type="' + selectedDataType + '"]')
          Severity: Major
          Found in public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js and 1 other location - About 1 hr to fix
          public_html/layouts/basic/modules/Settings/Leads/resources/LeadMapping.js on lines 117..122

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 55.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status