Showing 2 of 4 total issues
Method find_or_create_from_hash has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def self.find_or_create_from_hash(json, repo)
issuer = Coder.find_or_create_by_github_name(json['user']['login'])
begin
Issue.find_or_create_by(number: json['number'], repository: repo) do |issue|
issue.github_url = json['html_url']- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update_value! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
Open
def update_value!(new_value)
# Check whether the user has got enought points to spend
delta = new_value - value
if delta > issuer.bounty_residual
fail Error, "You don\'t have enough bounty points to put a bounty of"\- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"