Sign upLogin

Zorbash/response_mate

View on GitHub
Star

Showing 3 of 3 total issues

Method _utf8_encode has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def _utf8_encode(object)
    if object.respond_to? :force_encoding
      object.force_encoding('UTF-8').
             encode!('UTF-8', 'binary', invalid: :replace, undef: :replace, replace: '')
    elsif object.is_a? Hash
Severity: Minor
Found in lib/response_mate/tape.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fetch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def fetch(request) # rubocop:disable Metrics/AbcSize
    uri = URI.parse(request[:url])

    if request[:params]
      query = request[:params].to_query
Severity: Minor
Found in lib/response_mate/connection.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method write has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def write(key, request, response, meta = {}, output_dir = nil) # rubocop:disable Metrics/AbcSize
Severity: Minor
Found in lib/response_mate/tape.rb - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language