Showing 3 of 3 total issues
Method compare_score
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def compare_score(p1, p2, args=Hash.new(false)) # Determines who wins. parameter p1 is the player and parameter p2 is the dealer.
unless args[:compare]
win, lose, tie = "You win!", "Dealer wins.", "Tie"
else
win, lose, tie = true, false, nil
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
Open
elsif p2.value > p1.value then return lose
- Create a ticketCreate a ticket