ZuluPro/myblog

View on GitHub
myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js

Summary

Maintainability
F
3 days
Test Coverage

File foundation.reveal.js has 343 lines of code (exceeds 250 allowed). Consider refactoring.
Open

;(function ($, window, document, undefined) {
  'use strict';

  Foundation.libs.reveal = {
    name : 'reveal',
Severity: Minor
Found in myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js - About 4 hrs to fix

    Function open has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        open : function (target, ajax_settings) {
          var self = this,
              modal;
    
          if (target) {
    Severity: Major
    Found in myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js - About 2 hrs to fix

      Function events has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          events : function (scope) {
            var self = this,
                S = self.S;
      
            S(this.scope)
      Severity: Major
      Found in myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js - About 2 hrs to fix

        Function show has 52 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            show : function (el, css) {
              // is modal
              if (css) {
                var settings = el.data(this.attr_name(true) + '-init') || this.settings,
                    root_element = settings.root_element;
        Severity: Major
        Found in myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js - About 2 hrs to fix

          Function hide has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              hide : function (el, css) {
                // is modal
                if (css) {
                  var settings = el.data(this.attr_name(true) + '-init');
                  settings = settings || this.settings;
          Severity: Minor
          Found in myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js - About 1 hr to fix

            Avoid too many return statements within this function.
            Open

                  return el.hide();
            Severity: Major
            Found in myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return el.show();
              Severity: Major
              Found in myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          return setTimeout(function () {
                            return el
                              .css(css)
                              .animate(end_css, settings.animation_speed, 'linear', function () {
                                this.locked = false;
                myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js on lines 298..306

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          return setTimeout(function () {
                            return el
                              .animate(end_css, settings.animation_speed, 'linear', function () {
                                this.locked = false;
                                el.css(css).trigger('closed').trigger('closed.fndtn.reveal');
                myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js on lines 340..347

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          return setTimeout(function () {
                            return el
                              .animate(end_css, settings.animation_speed, 'linear', function () {
                                this.locked = false;
                                el.css(css).trigger('closed').trigger('closed.fndtn.reveal');
                myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js on lines 353..360

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                          return setTimeout(function () {
                            return el
                              .css(css)
                              .animate(end_css, settings.animation_speed, 'linear', function () {
                                this.locked = false;
                myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js on lines 283..291

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                    data_attr: function (str) {
                      if (this.namespace.length > 0) {
                        return this.namespace + '-' + str;
                      }
                
                
                Severity: Minor
                Found in myblog/myapp/static/zinnia/js/foundation/foundation.reveal.js and 2 other locations - About 40 mins to fix
                myblog/myapp/static/zinnia/js/foundation/foundation.magellan.js on lines 170..176
                myblog/myapp/static/zinnia/js/foundation/foundation.tab.js on lines 155..161

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status