abelevtsov/XrmSoapSDK

View on GitHub
src/Xrm.Soap.Sdk/js/xrm.common.js

Summary

Maintainability
D
2 days
Test Coverage

File xrm.common.js has 427 lines of code (exceeds 250 allowed). Consider refactoring.
Open

Type.registerNamespace("Xrm.Common");

(function(global) {
    "use strict";

Severity: Minor
Found in src/Xrm.Soap.Sdk/js/xrm.common.js - About 6 hrs to fix

    Function addNotification has 50 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        this.addNotification = function(id, level, source, message) {
            /// <summary>
            /// Add a notification bar message with CRM 2011 style
            /// </summary>
            /// <param name="message" type="String">
    Severity: Minor
    Found in src/Xrm.Soap.Sdk/js/xrm.common.js - About 2 hrs to fix

      Function openCustomLookupDialog has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          this.openCustomLookupDialog = function(config) {
              const callee = config.callee;
              const lookupStyle = config.lookupStyle;
              const lookupTypes = config.lookupTypes;
              const additionalParams = config.additionalParams;
      Severity: Minor
      Found in src/Xrm.Soap.Sdk/js/xrm.common.js - About 1 hr to fix

        Function setFormViewMode has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            this.setFormViewMode = function(readOnly) {
                try {
                    if (readOnly) {
                        if (!Xrm.Page.ui) {
                            setTimeout(self.setFormViewMode, 100);
        Severity: Minor
        Found in src/Xrm.Soap.Sdk/js/xrm.common.js - About 1 hr to fix

          Function isUserInRole has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              this.isUserInRole = function(roleName) {
                  var serverUrl = xrmPage.context.getClientUrl(),
                      odataPath = "/xrmservices/2011/organizationdata.svc",
                      oDataEndpointUrl = serverUrl + odataPath + "/RoleSet",
                      requestResults = [],
          Severity: Minor
          Found in src/Xrm.Soap.Sdk/js/xrm.common.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.setAllRecommendedAttributesToRequired = function() {
                    const attributes = xrmPage.data.entity.attributes.get();
                    for (let name in attributes) {
                        if (attributes.hasOwnProperty(name)) {
                            const attribute = attributes[name];
            Severity: Major
            Found in src/Xrm.Soap.Sdk/js/xrm.common.js and 1 other location - About 3 hrs to fix
            src/Xrm.Soap.Sdk/js/xrm.common.js on lines 257..267

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 110.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.setAllMandatoryAttributesToNone = function() {
                    const attributes = xrmPage.data.entity.attributes.get();
                    for (let name in attributes) {
                        if (attributes.hasOwnProperty(name)) {
                            const attribute = attributes[name];
            Severity: Major
            Found in src/Xrm.Soap.Sdk/js/xrm.common.js and 1 other location - About 3 hrs to fix
            src/Xrm.Soap.Sdk/js/xrm.common.js on lines 245..255

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 110.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status