Sign upLogin

ablanco/yith-library-web-client

View on GitHub
Star

Showing 32 of 71 total issues

Function save has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        save: function ($form) {
            if (this.validate($form)) {
                var data = this.getFormData($form, (new Date()).getTime()),
                    that = this,
                    modal,
Severity: Minor
Found in yithwebclient/static/js/edit-controllers.js - About 1 hr to fix

    Function save has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            save: function ($form) {
            if (this.validate($form)) {
                var data = this.getFormData($form, (new Date()).getTime()),
                    that = this,
                    modal,
    Severity: Minor
    Found in yithwebclient/static/js/prod/yith-1.1.1.js - About 1 hr to fix

      Function save has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              save: function ($form) {
            if (this.validate($form)) {
                var data = this.getFormData($form, (new Date()).getTime()),
                    that = this,
                    modal,
      Severity: Minor
      Found in yithwebclient/static/js/prod/yith-1.1.0.js - About 1 hr to fix

        Function save has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                save: function ($form) {
            if (this.validate($form)) {
                var data = this.getFormData($form, (new Date()).getTime()),
                    that = this,
                    modal,
        Severity: Minor
        Found in yithwebclient/static/js/prod/yith-1.1.2.js - About 1 hr to fix

          Function save has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  save: function ($form) {
            if (this.validate($form)) {
                var data = this.getFormData($form, (new Date()).getTime()),
                    that = this,
                    callback;
          Severity: Minor
          Found in yithwebclient/static/js/prod/yith-1.0.0.js - About 1 hr to fix

            Function save has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    save: function ($form) {
            if (this.validate($form)) {
                var data = this.getFormData($form, (new Date()).getTime()),
                    that = this,
                    callback;
            Severity: Minor
            Found in yithwebclient/static/js/prod/yith-1.0.1.js - About 1 hr to fix

              Function save has 28 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      save: function ($form) {
            if (this.validate($form)) {
                var data = this.getFormData($form, (new Date()).getTime()),
                    that = this,
                    callback;
              Severity: Minor
              Found in yithwebclient/static/js/prod/yith-1.0.2.js - About 1 hr to fix

                Function cipher has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        cipher: function (masterPassword, secret, masterModal, indexCtrl, notEnforce) {
                Severity: Minor
                Found in yithwebclient/static/js/prod/yith-1.1.0.js - About 35 mins to fix

                  Function cipher has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          cipher: function (masterPassword, secret, masterModal, indexCtrl, notEnforce) {
                  Severity: Minor
                  Found in yithwebclient/static/js/prod/yith-1.1.2.js - About 35 mins to fix

                    Function cipher has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            cipher: function (masterPassword, secret, masterModal, indexCtrl, notEnforce) {
                    Severity: Minor
                    Found in yithwebclient/static/js/prod/yith-1.1.1.js - About 35 mins to fix

                      Function cipher has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              cipher: function (masterPassword, secret, masterModal, indexCtrl, notEnforce) {
                      Severity: Minor
                      Found in yithwebclient/static/js/views.js - About 35 mins to fix

                        Function list_passwords has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def list_passwords(request):
    google_analytics = None
    if 'yith_google_analytics' in request.registry.settings:
        if (not 'allow_google_analytics' in request.session and
                'access_code' in request.session):
                        Severity: Minor
                        Found in yithwebclient/views.py - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language