aceleradora-TW/nao-me-calo

View on GitHub
app/assets/javascripts/welcome.js

Summary

Maintainability
D
2 days
Test Coverage

Function initAutocomplete has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function initAutocomplete () {
  var mapField = $('#map')[0]
  map = new google.maps.Map(mapField, {
    center: {lat: -30.0277, lng: -51.2287},
    zoom: 12
Severity: Major
Found in app/assets/javascripts/welcome.js - About 2 hrs to fix

    File welcome.js has 258 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //= require header-mobile
    
    var autocomplete;
    var map;
    
    
    Severity: Minor
    Found in app/assets/javascripts/welcome.js - About 2 hrs to fix

      Function has too many statements (34). Maximum allowed is 30.
      Open

        $(document).ready(function(){
      Severity: Minor
      Found in app/assets/javascripts/welcome.js by eslint

      enforce a maximum number of statements allowed in function blocks (max-statements)

      The max-statements rule allows you to specify the maximum number of statements allowed in a function.

      function foo() {
        var bar = 1; // one statement
        var baz = 2; // two statements
        var qux = 3; // three statements
      }

      Rule Details

      This rule enforces a maximum number of statements allowed in function blocks.

      Options

      This rule has a number or object option:

      • "max" (default 10) enforces a maximum number of statements allows in function blocks

      Deprecated: The object property maximum is deprecated; please use the object property max instead.

      This rule has an object option:

      • "ignoreTopLevelFunctions": true ignores top-level functions

      max

      Examples of incorrect code for this rule with the default { "max": 10 } option:

      /*eslint max-statements: ["error", 10]*/
      /*eslint-env es6*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
      
        var foo11 = 11; // Too many.
      }
      
      let foo = () => {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
      
        var foo11 = 11; // Too many.
      };

      Examples of correct code for this rule with the default { "max": 10 } option:

      /*eslint max-statements: ["error", 10]*/
      /*eslint-env es6*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        return function () {
      
          // The number of statements in the inner function does not count toward the
          // statement maximum.
      
          return 42;
        };
      }
      
      let foo = () => {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        return function () {
      
          // The number of statements in the inner function does not count toward the
          // statement maximum.
      
          return 42;
        };
      }

      ignoreTopLevelFunctions

      Examples of additional correct code for this rule with the { "max": 10 }, { "ignoreTopLevelFunctions": true } options:

      /*eslint max-statements: ["error", 10, { "ignoreTopLevelFunctions": true }]*/
      
      function foo() {
        var foo1 = 1;
        var foo2 = 2;
        var foo3 = 3;
        var foo4 = 4;
        var foo5 = 5;
        var foo6 = 6;
        var foo7 = 7;
        var foo8 = 8;
        var foo9 = 9;
        var foo10 = 10;
        var foo11 = 11;
      }

      Related Rules

      • [complexity](complexity.md)
      • [max-depth](max-depth.md)
      • [max-len](max-len.md)
      • [max-nested-callbacks](max-nested-callbacks.md)
      • [max-params](max-params.md) Source: http://eslint.org/docs/rules/

      Function createPin has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function createPin(){
          for(var i = 0; i<locations.length; i++){
            var locate = locations[i];
            var iconColor = locate[3];
            var myLatLng = {lat: locate[1], lng: locate[2]};
      Severity: Minor
      Found in app/assets/javascripts/welcome.js - About 1 hr to fix

        Move the invocation into the parens that contain the function.
        Open

          (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
        Severity: Minor
        Found in app/assets/javascripts/welcome.js by eslint

        Require IIFEs to be Wrapped (wrap-iife)

        You can immediately invoke function expressions, but not function declarations. A common technique to create an immediately-invoked function expression (IIFE) is to wrap a function declaration in parentheses. The opening parentheses causes the contained function to be parsed as an expression, rather than a declaration.

        // function expression could be unwrapped
        var x = function () { return { y: 1 };}();
        
        // function declaration must be wrapped
        function () { /* side effects */ }(); // SyntaxError

        Rule Details

        This rule requires all immediately-invoked function expressions to be wrapped in parentheses.

        Options

        This rule has two options, a string option and an object option.

        String option:

        • "outside" enforces always wrapping the call expression. The default is "outside".
        • "inside" enforces always wrapping the function expression.
        • "any" enforces always wrapping, but allows either style.

        Object option:

        • "functionPrototypeMethods": true additionally enforces wrapping function expressions invoked using .call and .apply. The default is false.

        outside

        Examples of incorrect code for the default "outside" option:

        /*eslint wrap-iife: ["error", "outside"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        Examples of correct code for the default "outside" option:

        /*eslint wrap-iife: ["error", "outside"]*/
        
        var x = (function () { return { y: 1 };}()); // wrapped call expression

        inside

        Examples of incorrect code for the "inside" option:

        /*eslint wrap-iife: ["error", "inside"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped
        var x = (function () { return { y: 1 };}()); // wrapped call expression

        Examples of correct code for the "inside" option:

        /*eslint wrap-iife: ["error", "inside"]*/
        
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        any

        Examples of incorrect code for the "any" option:

        /*eslint wrap-iife: ["error", "any"]*/
        
        var x = function () { return { y: 1 };}(); // unwrapped

        Examples of correct code for the "any" option:

        /*eslint wrap-iife: ["error", "any"]*/
        
        var x = (function () { return { y: 1 };}()); // wrapped call expression
        var x = (function () { return { y: 1 };})(); // wrapped function expression

        functionPrototypeMethods

        Examples of incorrect code for this rule with the "inside", { "functionPrototypeMethods": true } options:

        /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
        
        var x = function(){ foo(); }()
        var x = (function(){ foo(); }())
        var x = function(){ foo(); }.call(bar)
        var x = (function(){ foo(); }.call(bar))

        Examples of correct code for this rule with the "inside", { "functionPrototypeMethods": true } options:

        /* eslint wrap-iife: [2, "inside", { functionPrototypeMethods: true }] */
        
        var x = (function(){ foo(); })()
        var x = (function(){ foo(); }).call(bar)

        Source: http://eslint.org/docs/rules/

        Expected an assignment or function call and instead saw an expression.
        Open

            (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
        Severity: Minor
        Found in app/assets/javascripts/welcome.js by eslint

        Disallow Unused Expressions (no-unused-expressions)

        An unused expression which has no effect on the state of the program indicates a logic error.

        For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

        Rule Details

        This rule aims to eliminate unused expressions which have no effect on the state of the program.

        This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

        var i = 0;
        function increment() { i += 1; }
        increment(); // return value is unused, but i changed as a side effect
        
        var nThings = 0;
        function Thing() { nThings += 1; }
        new Thing(); // constructed object is unused, but nThings changed as a side effect

        This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

        Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

        Options

        This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

        • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
        • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
        • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

        These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

        Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

        /*eslint no-unused-expressions: "error"*/
        
        0
        
        if(0) 0
        
        {0}
        
        f(0), {}
        
        a && b()
        
        a, b()
        
        c = a, b;
        
        a() && function namedFunctionInExpressionContext () {f();}
        
        (function anIncompleteIIFE () {});
        
        injectGlobal`body{ color: red; }`

        Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

        "use strict";
        "use asm"
        "use stricter";
        "use babel"
        "any other strings like this in the prologue";

        Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

        /*eslint no-unused-expressions: "error"*/
        
        {} // In this context, this is a block statement, not an object literal
        
        {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
        
        function namedFunctionDeclaration () {}
        
        (function aGenuineIIFE () {}());
        
        f()
        
        a = 0
        
        new C
        
        delete a.b
        
        void a

        allowShortCircuit

        Examples of incorrect code for the { "allowShortCircuit": true } option:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
        
        a || b

        Examples of correct code for the { "allowShortCircuit": true } option:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
        
        a && b()
        a() || (b = c)

        allowTernary

        Examples of incorrect code for the { "allowTernary": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
        
        a ? b : 0
        a ? b : c()

        Examples of correct code for the { "allowTernary": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
        
        a ? b() : c()
        a ? (b = c) : d()

        allowShortCircuit and allowTernary

        Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
        
        a ? b() || (c = d) : e()

        allowTaggedTemplates

        Examples of incorrect code for the { "allowTaggedTemplates": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
        
        `some untagged template string`;

        Examples of correct code for the { "allowTaggedTemplates": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
        
        tag`some tagged template string`;

        Source: http://eslint.org/docs/rules/

        Expected an assignment or function call and instead saw an expression.
        Open

          (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
        Severity: Minor
        Found in app/assets/javascripts/welcome.js by eslint

        Disallow Unused Expressions (no-unused-expressions)

        An unused expression which has no effect on the state of the program indicates a logic error.

        For example, n + 1; is not a syntax error, but it might be a typing mistake where a programmer meant an assignment statement n += 1; instead.

        Rule Details

        This rule aims to eliminate unused expressions which have no effect on the state of the program.

        This rule does not apply to function calls or constructor calls with the new operator, because they could have side effects on the state of the program.

        var i = 0;
        function increment() { i += 1; }
        increment(); // return value is unused, but i changed as a side effect
        
        var nThings = 0;
        function Thing() { nThings += 1; }
        new Thing(); // constructed object is unused, but nThings changed as a side effect

        This rule does not apply to directives (which are in the form of literal string expressions such as "use strict"; at the beginning of a script, module, or function).

        Sequence expressions (those using a comma, such as a = 1, b = 2) are always considered unused unless their return value is assigned or used in a condition evaluation, or a function call is made with the sequence expression value.

        Options

        This rule, in its default state, does not require any arguments. If you would like to enable one or more of the following you may pass an object with the options set as follows:

        • allowShortCircuit set to true will allow you to use short circuit evaluations in your expressions (Default: false).
        • allowTernary set to true will enable you to use ternary operators in your expressions similarly to short circuit evaluations (Default: false).
        • allowTaggedTemplates set to true will enable you to use tagged template literals in your expressions (Default: false).

        These options allow unused expressions only if all of the code paths either directly change the state (for example, assignment statement) or could have side effects (for example, function call).

        Examples of incorrect code for the default { "allowShortCircuit": false, "allowTernary": false } options:

        /*eslint no-unused-expressions: "error"*/
        
        0
        
        if(0) 0
        
        {0}
        
        f(0), {}
        
        a && b()
        
        a, b()
        
        c = a, b;
        
        a() && function namedFunctionInExpressionContext () {f();}
        
        (function anIncompleteIIFE () {});
        
        injectGlobal`body{ color: red; }`

        Note that one or more string expression statements (with or without semi-colons) will only be considered as unused if they are not in the beginning of a script, module, or function (alone and uninterrupted by other statements). Otherwise, they will be treated as part of a "directive prologue", a section potentially usable by JavaScript engines. This includes "strict mode" directives.

        "use strict";
        "use asm"
        "use stricter";
        "use babel"
        "any other strings like this in the prologue";

        Examples of correct code for the default { "allowShortCircuit": false, "allowTernary": false } options:

        /*eslint no-unused-expressions: "error"*/
        
        {} // In this context, this is a block statement, not an object literal
        
        {myLabel: someVar} // In this context, this is a block statement with a label and expression, not an object literal
        
        function namedFunctionDeclaration () {}
        
        (function aGenuineIIFE () {}());
        
        f()
        
        a = 0
        
        new C
        
        delete a.b
        
        void a

        allowShortCircuit

        Examples of incorrect code for the { "allowShortCircuit": true } option:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
        
        a || b

        Examples of correct code for the { "allowShortCircuit": true } option:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true }]*/
        
        a && b()
        a() || (b = c)

        allowTernary

        Examples of incorrect code for the { "allowTernary": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
        
        a ? b : 0
        a ? b : c()

        Examples of correct code for the { "allowTernary": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTernary": true }]*/
        
        a ? b() : c()
        a ? (b = c) : d()

        allowShortCircuit and allowTernary

        Examples of correct code for the { "allowShortCircuit": true, "allowTernary": true } options:

        /*eslint no-unused-expressions: ["error", { "allowShortCircuit": true, "allowTernary": true }]*/
        
        a ? b() || (c = d) : e()

        allowTaggedTemplates

        Examples of incorrect code for the { "allowTaggedTemplates": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
        
        `some untagged template string`;

        Examples of correct code for the { "allowTaggedTemplates": true } option:

        /*eslint no-unused-expressions: ["error", { "allowTaggedTemplates": true }]*/
        
        tag`some tagged template string`;

        Source: http://eslint.org/docs/rules/

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $("#bestPlacesButton").click(function(){
              $(this).addClass('Order-btn-pressed');
              $(this).css('font-size', '145%');
              $('#worstPlacesButton').removeClass('Order-btn-pressed');
              $('#worstPlacesButton').css('font-size', '120%');
        Severity: Major
        Found in app/assets/javascripts/welcome.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/welcome.js on lines 295..300

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $("#worstPlacesButton").click(function(){
              $(this).addClass('Order-btn-pressed');
              $(this).css('font-size', '145%');
              $('#bestPlacesButton').removeClass('Order-btn-pressed');
              $('#bestPlacesButton').css('font-size', '120%');
        Severity: Major
        Found in app/assets/javascripts/welcome.js and 1 other location - About 2 hrs to fix
        app/assets/javascripts/welcome.js on lines 287..293

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 82.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function upperFontSize() {
              var max = 18
              if(actualFontSize<max){
                actualFontSize = actualFontSize+2;
                $("body").css("font-size", actualFontSize + "px");
        Severity: Major
        Found in app/assets/javascripts/welcome.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/welcome.js on lines 249..256

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function lowerFontSize(){
              var min = 14
              if(actualFontSize>min){
                actualFontSize = actualFontSize-2;
                $("body").css("font-size", actualFontSize + "px");
        Severity: Major
        Found in app/assets/javascripts/welcome.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/welcome.js on lines 258..265

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 59.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function switchListBest(){
              if($('#bottom5').is(":visible")){
                $('#top5').show();
                $('#bottom5').hide();
              }
        Severity: Major
        Found in app/assets/javascripts/welcome.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/welcome.js on lines 242..247

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          function fillSearch(){
            var place = searchBox.getPlace();
            $('#placeId2').val(place.place_id);
            $('#search-btn').click();
          }
        Severity: Major
        Found in app/assets/javascripts/welcome.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/welcome.js on lines 97..101

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            function switchListWorst(){
              if($("#top5").is(":visible")){
                $('#top5').hide();
                $('#bottom5').show();
              }
        Severity: Major
        Found in app/assets/javascripts/welcome.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/welcome.js on lines 235..240

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          function fillName(){
            var place = autocomplete.getPlace();
            $('#placeId').val(place.place_id);
            $('#rate-btn').click();
          }
        Severity: Major
        Found in app/assets/javascripts/welcome.js and 1 other location - About 1 hr to fix
        app/assets/javascripts/welcome.js on lines 103..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $('#formSearch').submit(function(e){
              if($('#placeId2').val() === ''){
                e.preventDefault();
              }
            });
        Severity: Minor
        Found in app/assets/javascripts/welcome.js and 1 other location - About 55 mins to fix
        app/assets/javascripts/welcome.js on lines 311..315

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $('#formEvaluate').submit(function(e){
              if($('#placeId').val() === ''){
                e.preventDefault();
              }
            });
        Severity: Minor
        Found in app/assets/javascripts/welcome.js and 1 other location - About 55 mins to fix
        app/assets/javascripts/welcome.js on lines 317..321

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status