Showing 992 of 1,478 total issues
Method add_credit_card
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def add_credit_card(xml, payment, options = {}, credit_envelope = 'v1')
if payment&.is_a?(CreditCard)
requires!(options.merge!({ card_number: payment.number, month: payment.month, year: payment.year }), :card_number, :month, :year)
xml.tag!("#{credit_envelope}:CreditCardData") do
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_customer_details
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def add_customer_details(post, payment, options)
if address = options[:billing_address] || options[:address]
post[:sg_FirstName] = payment.first_name if payment.respond_to?(:first_name)
post[:sg_LastName] = payment.last_name if payment.respond_to?(:last_name)
post[:sg_Address] = address[:address1] if address[:address1]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_post_for_auth_or_purchase
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
def create_post_for_auth_or_purchase(token, money, options)
{
'token' => token,
'orderDescription' => options[:description] || 'Worldpay Order',
'amount' => money,
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Class DataCashGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class DataCashGateway < Gateway
self.default_currency = 'GBP'
self.supported_countries = ['GB']
self.supported_cardtypes = %i[visa master american_express discover diners_club jcb maestro]
Class WorldpayUsGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class WorldpayUsGateway < Gateway
class_attribute :backup_url
self.display_name = 'Worldpay US'
self.homepage_url = 'http://www.worldpay.com/us'
Class DatatransGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class DatatransGateway < Gateway
self.test_url = 'https://api.sandbox.datatrans.com/v1/transactions/'
self.live_url = 'https://api.datatrans.com/v1/transactions/'
self.supported_countries = %w(CH GR US) # to confirm the countries supported.
Class BamboraApacGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class BamboraApacGateway < Gateway
self.live_url = 'https://www.bambora.co.nz/interface/api'
self.test_url = 'https://demo.bambora.co.nz/interface/api'
self.supported_countries = %w[AU NZ]
Class AlliedWalletGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class AlliedWalletGateway < Gateway
self.display_name = 'Allied Wallet'
self.homepage_url = 'https://www.alliedwallet.com'
self.live_url = 'https://api.alliedwallet.com/merchants/'
Class ConektaGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class ConektaGateway < Gateway
self.live_url = 'https://api.conekta.io/'
self.supported_countries = ['MX']
self.supported_cardtypes = %i[visa master american_express carnet]
Class ClearhausGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class ClearhausGateway < Gateway
self.test_url = 'https://gateway.test.clearhaus.com'
self.live_url = 'https://gateway.clearhaus.com'
self.supported_countries = %w[DK NO SE FI DE CH NL AD AT BE BG HR CY CZ FO GL EE FR GR
Class ProPayGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class ProPayGateway < Gateway
self.test_url = 'https://xmltest.propay.com/API/PropayAPI.aspx'
self.live_url = 'https://epay.propay.com/api/propayapi.aspx'
self.supported_countries = %w[US CA]
Class FirstPayJsonGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class FirstPayJsonGateway < Gateway
include FirstPayCommon
ACTIONS = {
purchase: 'Sale',
Class EfsnetGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class EfsnetGateway < Gateway
self.supported_countries = ['US']
self.supported_cardtypes = %i[visa master american_express discover]
self.homepage_url = 'http://www.concordefsnet.com/'
self.display_name = 'Efsnet'
Class Flo2cashGateway
has 22 methods (exceeds 20 allowed). Consider refactoring. Open
class Flo2cashGateway < Gateway
self.display_name = 'Flo2Cash'
self.homepage_url = 'http://www.flo2cash.co.nz/'
self.test_url = 'https://demo.flo2cash.co.nz/ws/paymentws.asmx'
File safe_charge.rb
has 263 lines of code (exceeds 250 allowed). Consider refactoring. Open
require 'nokogiri'
module ActiveMerchant #:nodoc:
module Billing #:nodoc:
class SafeChargeGateway < Gateway
Method request
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def request(method, body, headers = {})
request_start = Process.clock_gettime(Process::CLOCK_MONOTONIC)
headers = headers.dup
headers['connection'] ||= 'close'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_address
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def add_address(params, options)
address = options[:billing_address] || options[:address]
if address
params[:address] = address[:address1] unless address[:address1].blank?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_3ds
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def add_3ds(post, options)
if three_ds_2_options = options[:three_ds_2]
device_channel = three_ds_2_options[:channel]
if device_channel == 'app'
post[:threeDS2RequestData] = { deviceChannel: device_channel }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_billing_address
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def add_billing_address(post, payment, options)
return unless billing = options[:billing_address]
billing_address = {}
if payment.is_a?(CreditCard)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_aggregate_data
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def add_aggregate_data(post, options)
aggregate_data = {}
data = options[:aggregate_data]
aggregate_data[:indicator] = data[:indicator] if data[:indicator]
aggregate_data[:identification_number] = data[:identification_number] if data[:identification_number]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"